[lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo` types
ClosedPublic
Actions

Authored by atul on Mar 20 2023, 2:20 PM.

Details

Reviewers

ginsu
ashoat

Commits

rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`…

Summary

Add avatar field to *UserInfo types. Based on discussion w/ @ginsu.

Test Plan

Will be tested implicitly by subsequent diffs.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 20 2023, 2:20 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 20 2023, 2:20 PM

atul published this revision for review.Mar 20 2023, 2:28 PM

atul added 1 blocking reviewer(s): ginsu.

Harbormaster completed remote builds in B17433: Diff 23887.Mar 20 2023, 2:35 PM

ashoat accepted this revision.Mar 20 2023, 3:09 PM

ginsu accepted this revision.Mar 20 2023, 3:45 PM

This revision is now accepted and ready to land.Mar 20 2023, 3:45 PM

rebase and land

This revision was landed with ongoing or failed builds.Mar 20 2023, 3:48 PM

Closed by commit rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMbcb8e9e4126e: [lib] Introduce `ClientAvatar` and introduce `avatar` field for `*UserInfo`….

Harbormaster completed remote builds in B17447: Diff 23903.Mar 20 2023, 4:00 PM

Revision Contents
Changeset List

Path

Size

lib/

types/

avatar-types.js

12 lines

user-types.js

8 lines

Diff 23904

View Options

lib/types/avatar-types.js