Page MenuHomePhabricator

[native] render thread avatar in CHANNEL AVATAR thread settings section
ClosedPublic

Authored by ginsu on Mar 21 2023, 10:47 PM.
Tags
None
Referenced Files
F1434136: D7135.id24219.diff
Thu, Mar 28, 8:33 AM
F1434135: D7135.id24214.diff
Thu, Mar 28, 8:33 AM
F1434134: D7135.id23966.diff
Thu, Mar 28, 8:33 AM
F1434133: D7135.id24143.diff
Thu, Mar 28, 8:33 AM
F1434132: D7135.id23972.diff
Thu, Mar 28, 8:33 AM
F1434124: D7135.id.diff
Thu, Mar 28, 8:32 AM
F1434117: D7135.diff
Thu, Mar 28, 8:30 AM
Unknown Object (File)
Thu, Mar 7, 5:54 AM
Subscribers

Details

Summary

Introduce CHANNEL AVATAR section in thread settings and render thread avatar in this new section


Depends on D7134

Test Plan

Please take a look at the screenshots to see the changes I made:

staff user:

Screenshot 2023-03-22 at 3.34.29 AM.png (1×1 px, 816 KB)

non staff user:

Screenshot 2023-03-22 at 3.34.54 AM.png (1×1 px, 611 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)

update prop types for thread settings avatar

ashoat added inline comments.
native/chat/settings/thread-settings-avatar.react.js
19 ↗(On Diff #23972)

You could skip this memo and even improve performance slightly by just wrapping the whole component in React.memo

This revision is now accepted and ready to land.Mar 22 2023, 12:29 PM

address feedback