Differential D7158

native] fetch user avatar column from users table for remaning user fetchers"
ClosedPublic
Actions

Authored by ginsu on Mar 23 2023, 8:17 PM.

Details

Reviewers: None
Commits: rCOMMc3011806b124: Revert "[keyserver/lib/web/native] fetch user avatar column from users table…

Summary

This reverts commit 126db3bda66c39bac09f4f71957097a114521527.

Test Plan

n/a accidently hit the push button on my code editor

Diff Detail

Repository

rCOMM Comm

Branch

eng-2006 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Mar 23 2023, 8:17 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 23 2023, 8:17 PM

This revision was not accepted when it landed; it landed in state Draft.Mar 23 2023, 8:25 PM

This revision was landed with ongoing or failed builds.

Closed by commit rCOMMc3011806b124: Revert "[keyserver/lib/web/native] fetch user avatar column from users table…. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMc3011806b124: Revert "[keyserver/lib/web/native] fetch user avatar column from users table….

Harbormaster failed remote builds in B17562: Diff 24042!Mar 23 2023, 8:33 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

user-fetchers.js

12 lines

push/

send.js

3 lines

search/

users.js

3 lines

socket/

session-utils.js

4 lines

lib/

selectors/

relationship-selectors.js

13 lines

user-selectors.js

14 lines

shared/

message-utils.js

1 line

reaction-utils.test.js

48 lines

thread-utils.js

5 lines

types/

thread-types.js

1 line

native/

profile/

relationship-list-item.react.js

4 lines

relationship-list.react.js

4 lines

web/

modals/

threads/

create/

steps/

subchannel-members-list.react.js

12 lines

settings/

relationship/

add-users-list.react.js

6 lines

user-list.react.js

3 lines

Diff 24042

View Options

keyserver/src/fetchers/user-fetchers.js

View Options

keyserver/src/push/send.js

View Options

keyserver/src/search/users.js

View Options

keyserver/src/socket/session-utils.js

View Options

lib/selectors/relationship-selectors.js

View Options

lib/selectors/user-selectors.js

View Options

lib/shared/message-utils.js

View Options

lib/shared/reaction-utils.test.js

View Options

lib/shared/thread-utils.js

View Options

lib/types/thread-types.js

View Options

native/profile/relationship-list-item.react.js

View Options

native/profile/relationship-list.react.js

View Options

web/modals/threads/create/steps/subchannel-members-list.react.js

View Options

web/settings/relationship/add-users-list.react.js

View Options

web/settings/relationship/user-list.react.js

Revert "[keyserver/lib/web/native] fetch user avatar column from users table for remaning user fetchers"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 24042

keyserver/src/fetchers/user-fetchers.js

keyserver/src/push/send.js

keyserver/src/search/users.js

keyserver/src/socket/session-utils.js

lib/selectors/relationship-selectors.js

lib/selectors/user-selectors.js

lib/shared/message-utils.js

lib/shared/reaction-utils.test.js

lib/shared/thread-utils.js

lib/types/thread-types.js

native/profile/relationship-list-item.react.js

native/profile/relationship-list.react.js

web/modals/threads/create/steps/subchannel-members-list.react.js

web/settings/relationship/add-users-list.react.js

web/settings/relationship/user-list.react.js

Revert "[keyserver/lib/web/native] fetch user avatar column from users table for remaning user fetchers"
ClosedPublic
Actions

Revision Contents
Changeset List