Differential D7164

[keyserver] Launch NSE for build 199 and above
ClosedPublic
Actions

Authored by ashoat on Mar 23 2023, 8:31 PM.

Tags

None

Referenced Files

	F1683062: D7164.diff
	Tue, Apr 30, 8:00 AM

	Unknown Object (File)
	Tue, Apr 23, 1:42 PM

	Unknown Object (File)
	Tue, Apr 23, 1:42 PM

	Unknown Object (File)
	Tue, Apr 23, 1:42 PM

	Unknown Object (File)
	Tue, Apr 23, 1:37 PM

	Unknown Object (File)
	Mar 5 2024, 11:47 PM

	Unknown Object (File)
	Mar 5 2024, 11:47 PM

	Unknown Object (File)
	Mar 5 2024, 11:47 PM

View All 50 Files

Subscribers

Details

Reviewers

marcin
atul

Commits

rCOMM8e3ede03a4e4: [keyserver] Launch NSE for build 199 and above

Summary

Builds 199-202 (inclusive) had some known issues, but none with NSE. So I figure it's safe to launch NSE on them.

We could alternately "play it safe" by only launching NSE for the latest public release (203 and above) while keeping NSE for the existing staff releases (200 and 202), but I figure that check would be too messy and it's not really necessary. But open to it if people think it's a good idea.

Test Plan

We tested the use of NSE by initially limiting its release to internal builds

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Mar 23 2023, 8:31 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 23 2023, 8:31 PM

Harbormaster completed remote builds in B17570: Diff 24057.Mar 23 2023, 8:47 PM

ashoat requested review of this revision.Mar 23 2023, 8:47 PM

atul accepted this revision.Mar 24 2023, 11:33 AM

This revision is now accepted and ready to land.Mar 24 2023, 11:33 AM

There shouldn't need to be any native release associated with this landing then, correct?

No, I don't think so

Closed by commit rCOMM8e3ede03a4e4: [keyserver] Launch NSE for build 199 and above (authored by ashoat). · Explain WhyMar 24 2023, 1:58 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8e3ede03a4e4: [keyserver] Launch NSE for build 199 and above.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

9 lines

Diff 24097

keyserver/src/push/send.js

Loading...