Page MenuHomePhabricator

[keyserver] Add node-fetch package
ClosedPublic

Authored by michal on Apr 3 2023, 3:31 AM.
Tags
None
Referenced Files
F1789886: D7282.diff
Sun, May 19, 6:36 AM
Unknown Object (File)
Apr 16 2024, 3:11 PM
Unknown Object (File)
Mar 27 2024, 10:25 PM
Unknown Object (File)
Mar 27 2024, 10:25 PM
Unknown Object (File)
Mar 27 2024, 10:24 PM
Unknown Object (File)
Mar 27 2024, 10:11 PM
Unknown Object (File)
Mar 8 2024, 1:40 AM
Unknown Object (File)
Mar 8 2024, 1:40 AM
Subscribers

Details

Summary

Adds node-fetch package for making requests to the WNS. It's a 2.x.x version and not 3.x.x because the newest version fails on jest tests because it's ESM-only. A lot of people are facing this issue: SO post, discussion on gh. I've tried a few workarounds but I couldn't get it to work.

  • 2.x.x is still getting security updated and bug fixes (the version I added here is from january 2023)
  • there are no flow-typed types for 3.x.x versions
  • fixing this issue might be connected to ENG-3414
  • we are planning to move to fetch anyway after updating the node version D7253
Test Plan

yarn cleaninstall, check if CI passes

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage