Page MenuHomePhabricator
Differential D7300

[lib] Update `thread-ops-utils` to handle `avatar` field
ClosedPublic
Actions

Authored by atul on Apr 4 2023, 11:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 9:55 AM
Unknown Object (File)
Tue, Nov 5, 10:24 PM
Unknown Object (File)
Tue, Nov 5, 10:24 PM
Unknown Object (File)
Tue, Nov 5, 2:23 AM
Unknown Object (File)
Mon, Nov 4, 8:31 AM
Unknown Object (File)
Mon, Nov 4, 3:34 AM
Unknown Object (File)
Oct 28 2024, 2:26 PM
Unknown Object (File)
Oct 28 2024, 2:26 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM9d04746c4b05: [lib] Update `thread-ops-utils` to handle `avatar` field
Summary

Update convertRawThreadInfoToClientDBThreadInfo and convertClientDBThreadInfoToRawThreadInfo to accomodate avatar field.

Test Plan
  1. Set breakpoints and logged output of both functions in my local environment.
  2. Made sure that we DON'T set avatar: null in RawThreadInfo if avatar is null on the SQLite side, we instead exclude it entirely.

Will also write some quick unit tests as a sanity check.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D7300 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 4 2023, 11:25 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 4 2023, 11:25 AM
atul added inline comments.Apr 4 2023, 11:26 AM
lib/types/thread-types.js
305 ↗(On Diff #24619)

This was incorrect, ClientDB*Info types should only have (?)string/(?)number fields.

atul published this revision for review.Apr 4 2023, 11:26 AM
ashoat accepted this revision.Apr 4 2023, 11:33 AM
This revision is now accepted and ready to land.Apr 4 2023, 11:33 AM
Harbormaster completed remote builds in B17979: Diff 24619.Apr 4 2023, 11:47 AM
atul added a child revision: D7303: [lib] Introduce basic unit tests for `ThreadOpsUtils`.Apr 4 2023, 12:32 PM
atul updated this revision to Diff 24637.Apr 4 2023, 12:36 PM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 4 2023, 12:37 PM
Closed by commit rCOMM9d04746c4b05: [lib] Update `thread-ops-utils` to handle `avatar` field (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM9d04746c4b05: [lib] Update `thread-ops-utils` to handle `avatar` field.
Harbormaster completed remote builds in B17984: Diff 24637.Apr 4 2023, 12:52 PM

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
utils/
23 lines

Diff 24637

View Options

lib/types/thread-types.js

Loading...
View Options

lib/utils/thread-ops-utils.js

Loading...