Page MenuHomePhabricator
Differential D7307

[identity] fix CORS
ClosedPublic
Actions

Authored by varun on Apr 4 2023, 3:32 PM.
Tags
None
Referenced Files
F2170515: D7307.id.diff
Tue, Jul 2, 2:28 PM
Unknown Object (File)
Sat, Jun 29, 6:21 PM
Unknown Object (File)
May 29 2024, 6:38 AM
Unknown Object (File)
May 29 2024, 6:38 AM
Unknown Object (File)
May 29 2024, 6:38 AM
Unknown Object (File)
May 29 2024, 6:38 AM
Unknown Object (File)
May 13 2024, 9:35 AM
Unknown Object (File)
Apr 17 2024, 11:26 PM
View All 55 Files
Subscribers
atul
tomek

Details

Reviewers
ashoat
• jon
Commits
rCOMMf7a1a6709e43: [identity] fix CORS
Summary

i was going to manually implement a CORS layer on our service, but tonic-web just added a much easier way to enable CORS in v0.9.1

Test Plan

followed the steps here and got back an OK response on web for the GenerateNonce RPC

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Apr 4 2023, 3:32 PM
Herald added a reviewer: • jon. · View Herald TranscriptApr 4 2023, 3:32 PM
Herald added subscribers: atul, tomek. · View Herald Transcript
varun published this revision for review.Apr 4 2023, 3:34 PM
varun added a comment.Apr 4 2023, 3:37 PM

I see result: GCEj5U5v0to1wXOkN in the console logs, so i think it's working fine now

Harbormaster completed remote builds in B17991: Diff 24645.Apr 4 2023, 3:49 PM
ashoat accepted this revision.Apr 4 2023, 3:58 PM
This revision is now accepted and ready to land.Apr 4 2023, 3:58 PM
ashoat added a comment.Apr 4 2023, 3:58 PM

Thanks for fixing this so quickly!

Closed by commit rCOMMf7a1a6709e43: [identity] fix CORS (authored by varun). · Explain WhyApr 4 2023, 4:01 PM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMf7a1a6709e43: [identity] fix CORS.

Revision Contents
Changeset List

PathSize
services/
identity/
6 lines
src/
4 lines

Diff 24646

View Options

services/identity/Cargo.lock

Loading...
View Options

services/identity/Cargo.toml

Loading...
View Options

services/identity/src/main.rs

Loading...