[keyserver] Split fetchServerThreadInfos into two queries
ClosedPublic
Actions

Authored by ashoat on Apr 5 2023, 11:15 AM.

Details

Reviewers

tomek
atul
• jon

Commits

rCOMM9170255b19a4: [keyserver] Split fetchServerThreadInfos into two queries

Summary

Addresses ENG-3606.

Test Plan

I tested by comparing the JSON.stringify'd results before and after this change using this patch: https://gist.github.com/Ashoat/f07fc27a8fe4c456fd5d675a802b3cad

No differences were found.

I'm now in the process of deploying this change to prod so we can test it there.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 5 2023, 11:15 AM

atul published this revision for review.Apr 5 2023, 11:21 AM

Read through it a couple times carefully and I think this change should be good.

I tested by comparing the JSON.stringify'd results before and after this change using this patch: https://gist.github.com/Ashoat/f07fc27a8fe4c456fd5d675a802b3cad No differences were found.

Thanks, it's reassuring to know there's no difference with the tested query.

This revision is now accepted and ready to land.Apr 5 2023, 11:27 AM

Harbormaster completed remote builds in B18011: Diff 24672.Apr 5 2023, 11:32 AM

Closed by commit rCOMM9170255b19a4: [keyserver] Split fetchServerThreadInfos into two queries (authored by ashoat). · Explain WhyApr 5 2023, 11:39 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9170255b19a4: [keyserver] Split fetchServerThreadInfos into two queries.