Paths

Table of Contentst

Differential D7332

[keyserver] Modify `updateThread` to handle `avatar`s
ClosedPublic
Actions

Authored by atul on Apr 6 2023, 12:04 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 8, 9:59 AM

	Unknown Object (File)
	Fri, Nov 8, 9:59 AM

	Unknown Object (File)
	Fri, Nov 8, 9:59 AM

	Unknown Object (File)
	Thu, Nov 7, 10:50 AM

	Unknown Object (File)
	Thu, Nov 7, 10:49 AM

	Unknown Object (File)
	Tue, Nov 5, 2:30 AM

	Unknown Object (File)
	Tue, Nov 5, 2:29 AM

	Unknown Object (File)
	Tue, Nov 5, 2:29 AM

Subscribers

Details

Reviewers

ashoat
ginsu

Commits

rCOMMcb7dec7447bf: [keyserver] Modify `updateThread` to handle `avatar`s

Summary

Able to send avatar setting change to keyserver and have it reflected in the DB.

Test Plan

Able to see avatar field populated in threads table:

Able to see avatar change robotext (obviously needs to be changed):

Simulator Screenshot - Fresh iPhone 14 Pro - 2023-04-06 at 14.26.29.png (2×1 px, 322 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 6 2023, 12:04 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 6 2023, 12:04 PM

atul added a child revision: D7333: [keyserver] Update `fetchServerThreadInfos` to include `avatar` field.Apr 6 2023, 12:04 PM

atul published this revision for review.Apr 6 2023, 12:15 PM

atul mentioned this in D7320: [lib] Add `avatar` to `ThreadChanges`.

Harbormaster completed remote builds in B18056: Diff 24742.Apr 6 2023, 12:20 PM

atul edited the test plan for this revision. (Show Details)Apr 6 2023, 12:24 PM

Thanks for combining the diffs for me!

keyserver/src/updaters/thread-updaters.js
360 ↗	(On Diff #24742)	This can just be `if (avatar)`, no?

This revision is now accepted and ready to land.Apr 6 2023, 12:42 PM

atul added inline comments.Apr 6 2023, 12:53 PM

keyserver/src/updaters/thread-updaters.js
360 ↗	(On Diff #24742)	Ah yeah, I was matching the `description` and `threadType` checks but those explicitly check `null`/`undefined` to handle empty string case. Since `avatar` is object we can do a simple truthiness check. I'll update.

rebase before addressing feedback

check avatar truthiness directly

This revision was landed with ongoing or failed builds.Apr 6 2023, 2:09 PM

Closed by commit rCOMMcb7dec7447bf: [keyserver] Modify `updateThread` to handle `avatar`s (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMcb7dec7447bf: [keyserver] Modify `updateThread` to handle `avatar`s.

Harbormaster completed remote builds in B18062: Diff 24749.Apr 6 2023, 2:24 PM

Harbormaster failed remote builds in B18064: Diff 24751!Apr 6 2023, 2:34 PM

Harbormaster completed remote builds in B18064: Diff 24751.Apr 6 2023, 2:59 PM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

responders/

thread-responders.js

2 lines

updaters/

thread-updaters.js

13 lines

lib/

types/

thread-types.js

3 lines

Diff 24753

keyserver/src/responders/thread-responders.js

Loading...

keyserver/src/updaters/thread-updaters.js

Loading...

lib/types/thread-types.js

Loading...