Update updateUserAvatar to return properly constructed ClientImageAvatar if the request was of type image.
Depends on D7404
Details
Details
- Set image avatar for user
- Observe that UPDATE_USER_AVATAR_SUCCESS payload includes correctly constructed ClientImageAvatar
- Observe that UserAvatar component looks correct throughout native
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/src/updaters/account-updaters.js | ||
|---|---|---|
| 154–158 ↗ | (On Diff #25064) | It would be more correct if it was within the transaction as it would handle the case where there are multiple simultaneous calls to updateUserAvatar that may change the image avatar between the transaction being committed and this select statement returning its result set. However, then we'd need to index into resultSet with some sort of hard-coded value (5) to pull out these values. That seems like it might be more human error-prone if someone makes changes to query that causes the indices to shift? Personally would prefer hard-coding in a constant to ensure correctness, but figured I'd ask reviewers what they'd prefer. |