Page MenuHomePhabricator
Differential D7435

[keyserver] Fix `avatarUpdateQuery`
ClosedPublic
Actions

Authored by atul on Apr 13 2023, 1:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 4:24 AM
Unknown Object (File)
Tue, Nov 5, 4:23 AM
Unknown Object (File)
Fri, Nov 1, 1:03 AM
Unknown Object (File)
Fri, Nov 1, 1:03 AM
Unknown Object (File)
Fri, Nov 1, 1:03 AM
Unknown Object (File)
Fri, Nov 1, 1:02 AM
Unknown Object (File)
Fri, Nov 1, 12:54 AM
Unknown Object (File)
Oct 12 2024, 2:53 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMb367a4710322: [keyserver] Fix `avatarUpdateQuery`
Summary

Just introduced this in D7430 and noticed a slight issue that left container column of an image avatar set until we set another image avatar.

Specifically, if we had an image avatar and switched to emoji avatar the container field of the previous image avatar upload would remain set.

This wouldn't cause any issues in practice (as things are now), but the state of the DB would not be "corrected" until we subsequently set an image avatar.

In order to fix this we adjust the logic to match what we have in the final UPDATE threads... query.

Test Plan
  1. Switch from image avatar to image avatar and ensure that contents of uploads table and threads table are correct.
  2. Switch from image avatar to emoji avatar and ensure that contents of uploads table and threads table are correct.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 13 2023, 1:58 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 13 2023, 1:58 PM
atul edited the summary of this revision. (Show Details)Apr 13 2023, 1:59 PM
atul published this revision for review.Apr 13 2023, 2:01 PM
atul added inline comments.
keyserver/src/updaters/thread-updaters.js
664–666 ↗(On Diff #25143)

Got it right here...

Harbormaster completed remote builds in B18350: Diff 25143.Apr 13 2023, 2:16 PM
atul mentioned this in D7437: [keyserver] Fix `updateUserAvatar` query.Apr 13 2023, 3:22 PM
atul added a child revision: D7437: [keyserver] Fix `updateUserAvatar` query.Apr 13 2023, 4:03 PM
ashoat accepted this revision.Apr 14 2023, 6:44 AM
This revision is now accepted and ready to land.Apr 14 2023, 6:44 AM
atul updated this revision to Diff 25192.Apr 16 2023, 10:41 AM

rebase and land

This revision was landed with ongoing or failed builds.Apr 16 2023, 10:48 AM
Closed by commit rCOMMb367a4710322: [keyserver] Fix `avatarUpdateQuery` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMb367a4710322: [keyserver] Fix `avatarUpdateQuery`.
Harbormaster completed remote builds in B18387: Diff 25192.Apr 16 2023, 10:59 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
20 lines

Diff 25193

View Options

keyserver/src/updaters/thread-updaters.js

Loading...