Page MenuHomePhabricator
Differential D7475

[native] Move definition of `onTranscodingProgress` outside of `mediaProcessConfig`
AbandonedPublicDraft
Actions

Authored by atul on Apr 17 2023, 1:18 PM.
Tags
None
Referenced Files
F2903632: D7475.diff
Sat, Oct 5, 11:30 PM
Unknown Object (File)
Fri, Oct 4, 10:21 AM
Unknown Object (File)
Tue, Sep 24, 5:06 AM
Unknown Object (File)
Wed, Sep 11, 3:47 PM
Unknown Object (File)
Wed, Sep 11, 3:47 PM
Unknown Object (File)
Wed, Sep 11, 3:41 PM
Unknown Object (File)
Sep 3 2024, 6:52 AM
Unknown Object (File)
Aug 31 2024, 8:14 AM
View All 28 Files
Subscribers
ashoat
tomek

Details

Reviewers
None
Summary

It doesn't make sense to define onTranscodingProgress inside of mediaProcessConfig. Instead it makes sense to define onTranscodingProgress callback at callsite and pass into mediaProcessConfig. This also makes mediaProcessConfig more generally useful.

I initially added the onTranscodingProgress stuff to InputStateContainer so my bad.

(I'm NOT planning on doing any more refactoring here. This was confusing and 2 min change so I just made it.)

Test Plan

Still able to send video message and the transcoding progress shows up as expected.

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
input/
13 lines
media/
2 lines

Diff 25233

View Options

native/input/input-state-container.react.js

Loading...
View Options

native/media/media-utils.js

Loading...