Page MenuHomePhabricator
Differential D7503

[native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and EmojiThreadAvatarCreation
ClosedPublic
Actions

Authored by ginsu on Apr 18 2023, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 12:25 PM
Unknown Object (File)
Thu, Oct 31, 12:25 PM
Unknown Object (File)
Thu, Oct 31, 12:25 PM
Unknown Object (File)
Thu, Oct 31, 12:25 PM
Unknown Object (File)
Thu, Oct 31, 12:25 PM
Unknown Object (File)
Thu, Oct 31, 12:24 PM
Unknown Object (File)
Thu, Oct 31, 12:19 PM
Unknown Object (File)
Oct 7 2024, 3:28 AM
View All 97 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM0109468d1a2a: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and…
Summary

Copied the code in EmojiAvatarCreation and pasted it into both EmojiUserAvatarCreation and EmojiThreadAvatarCreation. Also updated the navigators and imports to use these two new components.

There is a bunch of shared code in EmojiUserAvatarCreation and EmojiThreadAvatarCreation, but the next diff will handle factoring out all the shared code back into EmojiAvatarCreation

Test Plan

Saving emoji avatar still works, no flow errors

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 18 2023, 1:11 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 18 2023, 1:12 PM
ginsu edited the summary of this revision. (Show Details)Apr 18 2023, 1:16 PM
ginsu added reviewers: ashoat, atul.
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 18 2023, 1:24 PM
Harbormaster failed remote builds in B18478: Diff 25304!
ginsu added a child revision: D7504: [native] factor out shared code between Emoji[User/Thread]AvatarCreation into EmojiAvatarCreation.Apr 18 2023, 1:27 PM
ginsu updated this revision to Diff 25311.Apr 18 2023, 1:37 PM

remove nav props to appease flow/eslint

ginsu added inline comments.Apr 18 2023, 1:43 PM
native/avatars/emoji-avatar-creation.react.js
43–49 ↗(On Diff #25311)

I know this is hacky, but this is needed to appease flow/eslint. I chose not to remove threadID and containingThreadID because

  1. It would require taking out a lot code to make things copacetic again and this diff would get super large
  2. At this point in the stack, this component is no longer used since we now call Emoji[User/Thread]AvatarCreation
  3. D7504 which is the next diff will resolve all this
Harbormaster completed remote builds in B18480: Diff 25311.Apr 18 2023, 1:55 PM
ginsu requested review of this revision.Apr 18 2023, 1:55 PM
ashoat accepted this revision.Apr 19 2023, 5:47 AM

Please address inline comment before landing

native/chat/settings/emoji-thread-avatar-creation.react.js
46 ↗(On Diff #25311)

This should not be a ProfileNavigationProp anymore, right? Should it be a ChatNavigationProp?

This revision is now accepted and ready to land.Apr 19 2023, 5:47 AM
ginsu updated this revision to Diff 25375.Apr 19 2023, 10:41 AM

address comments

Harbormaster completed remote builds in B18520: Diff 25375.Apr 19 2023, 10:59 AM
ginsu updated this revision to Diff 25389.Apr 19 2023, 12:33 PM

rebase before landing

This revision was landed with ongoing or failed builds.Apr 19 2023, 12:46 PM
Closed by commit rCOMM0109468d1a2a: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and… (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM0109468d1a2a: [native] naively split EmojiAvatarCreation into EmojiUserAvatarCreation and….
Harbormaster completed remote builds in B18528: Diff 25389.Apr 19 2023, 12:51 PM

Revision Contents
Changeset List

PathSize
native/
avatars/
8 lines
chat/
8 lines
settings/
6 lines
chat/
settings/
avatars/
emoji-thread-avatar-creation.react.js
emoji-avatar-creation.react.js
26 lines
navigation/
10 lines
profile/
avatars/
emoji-user-avatar-creation.react.js
emoji-avatar-creation.react.js
12 lines
profile/
6 lines
8 lines

Diff 25394

View Options

native/avatars/emoji-avatar-creation.react.js

Loading...
View Options

native/chat/chat.react.js

Loading...
View Options

native/chat/settings/emoji-thread-avatar-creation.react.js

Loading...
View Options

native/chat/settings/thread-settings-avatar.react.js

Loading...
View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/emoji-user-avatar-creation.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

native/profile/profile.react.js

Loading...