Paths

Table of Contentst

Differential D7529

[native] Show `ActivityIndicator` in `EditUserAvatar` during update
ClosedPublic
Actions

Authored by atul on Apr 19 2023, 11:46 AM.

Tags

None

Referenced Files

	F3150510: D7529.diff
	Mon, Nov 4, 11:24 PM

	Unknown Object (File)
	Fri, Nov 1, 9:13 AM

	Unknown Object (File)
	Fri, Nov 1, 9:13 AM

	Unknown Object (File)
	Fri, Nov 1, 9:12 AM

	Unknown Object (File)
	Fri, Nov 1, 9:09 AM

	Unknown Object (File)
	Mon, Oct 28, 8:26 PM

	Unknown Object (File)
	Oct 2 2024, 2:36 PM

	Unknown Object (File)
	Oct 1 2024, 12:31 PM

View All 78 Files

Subscribers

Details

Reviewers

ashoat
ginsu

Commits

rCOMM4fda6f042654: [native] Show `ActivityIndicator` in `EditUserAvatar` during update

Summary

We consume isGalleryAvatarUpdateLoading and isRemoveAvatarUpdateLoading introduced in previous diffs to display ActivityIndicator (ie spinner) when an update is in progress.

Note: Yeah there are obvious things that can be factored out. I want to get more of the error handling stuff done first and then I'll go through and consolidate things.

Depends on D7528

Test Plan

Works as expected:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 19 2023, 11:46 AM

Herald added a subscriber: tomek. · View Herald TranscriptApr 19 2023, 11:46 AM

atul published this revision for review.Apr 19 2023, 11:47 AM

atul edited the test plan for this revision. (Show Details)

atul added inline comments.

native/avatars/edit-user-avatar.react.js
50–52 ↗	(On Diff #25383)	Stole this from `LoadableImage`
65–75 ↗	(On Diff #25383)	I just stole this from `LoadableImage`

ashoat accepted this revision.Apr 19 2023, 11:59 AM

This revision is now accepted and ready to land.Apr 19 2023, 11:59 AM

Harbormaster completed remote builds in B18526: Diff 25383.Apr 19 2023, 12:04 PM

atul added a child revision: D7530: [native] Replace logging with `Alert`s in `selectFromGalleryAndUpdateUserAvatar`.Apr 19 2023, 12:06 PM

Closed by commit rCOMM4fda6f042654: [native] Show `ActivityIndicator` in `EditUserAvatar` during update (authored by atul). · Explain WhyApr 19 2023, 12:28 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM4fda6f042654: [native] Show `ActivityIndicator` in `EditUserAvatar` during update.

atul mentioned this in D7547: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.Apr 19 2023, 4:45 PM

atul mentioned this in rCOMM61eb0e026466: [native] Match changes made to `EditUserAvatar` for `EditThreadAvatar`.Apr 19 2023, 8:29 PM

Revision Contents
Changeset List

Path

Size

native/

avatars/

edit-user-avatar.react.js

33 lines

Diff 25388

native/avatars/edit-user-avatar.react.js

Loading...