Page MenuHomePhabricator
Differential D7543

[native] Alert user when `UPDATE_USER_AVATAR` call fails
ClosedPublic
Actions

Authored by atul on Apr 19 2023, 2:02 PM.
Tags
None
Referenced Files
F2147083: D7543.id25431.diff
Sun, Jun 30, 12:58 AM
F2145211: D7543.id25427.diff
Sat, Jun 29, 9:38 PM
Unknown Object (File)
Sat, Jun 29, 6:52 AM
Unknown Object (File)
Fri, Jun 28, 6:06 PM
Unknown Object (File)
Fri, Jun 28, 6:06 PM
Unknown Object (File)
Fri, Jun 28, 6:06 PM
Unknown Object (File)
Fri, Jun 28, 6:06 PM
Unknown Object (File)
Fri, Jun 28, 6:05 PM
View All 62 Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM040694b61c0b: [native] Alert user when `UPDATE_USER_AVATAR` call fails
Summary

Handled image selection/processing/upload in D7530, this handles the update avatar call in a slightly different way (as discussed in the that diff)

Test Plan

Modify updateUserAvatarResponder to make sure request fails and observe that Alert appeared as expected:

e4544c.png (1×2 px, 881 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 19 2023, 2:02 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 19 2023, 2:02 PM
atul edited the test plan for this revision. (Show Details)Apr 19 2023, 2:02 PM
atul published this revision for review.Apr 19 2023, 2:05 PM
Harbormaster completed remote builds in B18546: Diff 25410.Apr 19 2023, 2:19 PM
atul added a comment.Apr 19 2023, 3:29 PM

I have no idea why, but it looks like this diff is breaking things..

atul planned changes to this revision.Apr 19 2023, 3:31 PM
atul requested review of this revision.

Oh no shit it wasn't updating the image.... I'm awaiting without returning smh

atul updated this revision to Diff 25427.Apr 19 2023, 3:33 PM

fix..

ginsu accepted this revision.Apr 19 2023, 3:43 PM

lgtm good catch with that bug

This revision is now accepted and ready to land.Apr 19 2023, 3:43 PM
Harbormaster failed remote builds in B18562: Diff 25427!Apr 19 2023, 3:48 PM
atul updated this revision to Diff 25430.Apr 19 2023, 4:07 PM

rebase and land

This revision was landed with ongoing or failed builds.Apr 19 2023, 4:08 PM
Closed by commit rCOMM040694b61c0b: [native] Alert user when `UPDATE_USER_AVATAR` call fails (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM040694b61c0b: [native] Alert user when `UPDATE_USER_AVATAR` call fails.
Harbormaster failed remote builds in B18564: Diff 25430!Apr 19 2023, 4:23 PM
ashoat added a comment.Apr 19 2023, 4:32 PM

The Android build was consistently failing here… any cause for concern?

atul added a comment.Apr 19 2023, 4:45 PM
In D7543#223748, @ashoat wrote:

The Android build was consistently failing here… any cause for concern?

Issue with maven pulling in dependencies

Revision Contents
Changeset List

PathSize
native/
avatars/
16 lines

Diff 25431

View Options

native/avatars/avatar-hooks.js

Loading...