Paths

Table of Contentst

[native] remove async in saveENSUserAvatar callback
ClosedPublic
Actions

Authored by ginsu on Apr 20 2023, 1:47 PM.

Tags

None

Referenced Files

	F2157468: D7555.diff
	Mon, Jul 1, 1:55 AM

	F2153673: D7555.id.diff
	Sun, Jun 30, 5:45 PM

	F2151359: D7555.id25552.diff
	Sun, Jun 30, 12:33 PM

	Unknown Object (File)
	Fri, Jun 28, 6:05 PM

	Unknown Object (File)
	Fri, Jun 28, 6:05 PM

	Unknown Object (File)
	Fri, Jun 28, 6:05 PM

	Unknown Object (File)
	Fri, Jun 28, 6:05 PM

	Unknown Object (File)
	Fri, Jun 28, 6:03 PM

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM5f1ae61d35dd: [native] remove async in saveENSUserAvatar callback

Summary

In D7547 @ashoat gave some feedback about removing the async in removeUserAvatar and removeThreadAvatar. We should do the same for saveENSUserAvatar

Test Plan

flow and everything still works

Diff Detail

Repository

rCOMM Comm

Branch

avatars-cleanup

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 20 2023, 1:47 PM

Herald added subscribers: atul, tomek. · View Herald TranscriptApr 20 2023, 1:47 PM

ginsu added reviewers: ashoat, atul.Apr 20 2023, 1:48 PM

Harbormaster completed remote builds in B18594: Diff 25471.Apr 20 2023, 2:08 PM

ginsu requested review of this revision.Apr 20 2023, 2:08 PM

ashoat accepted this revision.Apr 21 2023, 6:14 AM

This revision is now accepted and ready to land.Apr 21 2023, 6:14 AM

rebase before landing

Harbormaster completed remote builds in B18661: Diff 25552.Apr 21 2023, 11:55 AM

Closed by commit rCOMM5f1ae61d35dd: [native] remove async in saveENSUserAvatar callback (authored by ginsu). · Explain WhyApr 21 2023, 11:59 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM5f1ae61d35dd: [native] remove async in saveENSUserAvatar callback.

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

4 lines

Diff 25471

View Options

native/avatars/avatar-hooks.js

[native] remove async in saveENSUserAvatar callbackClosedPublicActions