Paths

Table of Contentst

[native] Add selection state to KeyserverSelection
ClosedPublic
Actions

Authored by ashoat on Apr 22 2023, 1:42 PM.

Details

Reviewers

ginsu
atul

Commits

rCOMM1e0c66a23f87: [native] Add selection state to KeyserverSelection

Summary

This diff adds React state for selection and the corresponding styles to match what's in Figma. To handle this in RegistrationTile I also introduce a React context that is internal to that file.

Depends on D7576

Test Plan

before	after

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 22 2023, 1:42 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 22 2023, 1:42 PM

ashoat edited the test plan for this revision. (Show Details)Apr 22 2023, 1:47 PM

ashoat attached a referenced file: F502099: Screenshot 2023-04-22 at 3.28.44 PM.png. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 22 2023, 1:55 PM

Harbormaster failed remote builds in B18669: Diff 25569!

Rebase on Android CI fix

Harbormaster completed remote builds in B18674: Diff 25574.Apr 22 2023, 2:53 PM

ashoat requested review of this revision.Apr 22 2023, 2:53 PM

atul accepted this revision.Apr 23 2023, 11:50 AM

This revision is now accepted and ready to land.Apr 23 2023, 11:50 AM

Closed by commit rCOMM1e0c66a23f87: [native] Add selection state to KeyserverSelection (authored by ashoat). · Explain WhyApr 23 2023, 4:40 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1e0c66a23f87: [native] Add selection state to KeyserverSelection.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

keyserver-selection.react.js

20 lines

registration-tile.react.js

71 lines

Diff 25584

View Options

native/account/registration/keyserver-selection.react.js