[lib] extend defaultEmojiAvatars
ClosedPublic
Actions

Authored by ginsu on Apr 23 2023, 8:12 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMMbc388f84a3a2: [lib] extend defaultEmojiAvatars

Summary

extend the defaultEmojiAvatars based off this list from Ted. As I was building the list I made sure that the emoji and background color had good contrast (a yellow emoji didn't have a yellow background)

Test Plan

I could see the new default emoji avatars rendered

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 23 2023, 8:12 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 23 2023, 8:12 PM

ginsu edited the summary of this revision. (Show Details)Apr 23 2023, 8:13 PM

ginsu added reviewers: ashoat, atul.

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 23 2023, 8:25 PM

Harbormaster failed remote builds in B18680: Diff 25585!

ginsu requested review of this revision.Apr 23 2023, 9:09 PM

ashoat accepted this revision.Apr 24 2023, 6:12 AM

This revision is now accepted and ready to land.Apr 24 2023, 6:12 AM

rebase before landing

Harbormaster completed remote builds in B18700: Diff 25610.Apr 24 2023, 8:29 AM

Closed by commit rCOMMbc388f84a3a2: [lib] extend defaultEmojiAvatars (authored by ginsu). · Explain WhyApr 24 2023, 9:16 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMbc388f84a3a2: [lib] extend defaultEmojiAvatars.

Revision Contents
Changeset List

Path

Size

lib/

shared/

avatar-utils.js

223 lines

Diff 25610

View Options

lib/shared/avatar-utils.js

[lib] extend defaultEmojiAvatarsClosedPublicActions