Page MenuHomePhabricator
Differential D7589

[native] fix rendering of edit thread description setting button
ClosedPublic
Actions

Authored by ginsu on Apr 24 2023, 11:41 AM.
Tags
None
Referenced Files
F1789828: D7589.diff
Sun, May 19, 6:02 AM
Unknown Object (File)
Tue, May 7, 11:55 PM
Unknown Object (File)
Thu, May 2, 12:00 AM
Unknown Object (File)
Apr 15 2024, 9:54 PM
Unknown Object (File)
Apr 15 2024, 3:58 PM
Unknown Object (File)
Apr 15 2024, 1:54 AM
Unknown Object (File)
Apr 15 2024, 12:57 AM
Unknown Object (File)
Apr 13 2024, 1:14 AM
View All 28 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMM6cda5f727b1e: [native] fix rendering of edit thread description setting button
Summary

Pretty much the same thing as D7588 but for the thread description

Depends on D7588

Test Plan

Please see the demo videos below to see the changes I made

Before:

After:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Apr 24 2023, 11:41 AM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 24 2023, 11:41 AM
ginsu edited the test plan for this revision. (Show Details)Apr 24 2023, 11:46 AM
ginsu added reviewers: ashoat, atul.
ginsu attached a referenced file: F505499: Screen Recording 2023-04-24 at 2.43.31 PM.mov. (Show Details)
ginsu edited the test plan for this revision. (Show Details)
ginsu attached a referenced file: F505503: Screen Recording 2023-04-24 at 2.47.22 PM.mov. (Show Details)
ginsu attached a referenced file: F505498: Screen Recording 2023-04-24 at 2.45.04 PM.mov. (Show Details)
ginsu edited the summary of this revision. (Show Details)Apr 24 2023, 11:50 AM
ginsu added a parent revision: D7588: [native] fix rendering of edit thread name settings button.
Harbormaster completed remote builds in B18705: Diff 25616.Apr 24 2023, 11:59 AM
ginsu requested review of this revision.Apr 24 2023, 11:59 AM
ashoat accepted this revision.Apr 24 2023, 12:36 PM
This revision is now accepted and ready to land.Apr 24 2023, 12:36 PM
Closed by commit rCOMM6cda5f727b1e: [native] fix rendering of edit thread description setting button (authored by ginsu). · Explain WhyApr 24 2023, 12:42 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6cda5f727b1e: [native] fix rendering of edit thread description setting button.

Revision Contents
Changeset List

PathSize
native/
chat/
settings/
41 lines

Diff 25616

View Options

native/chat/settings/thread-settings-description.react.js

Loading...