add threadID to the thread settings loading status selector custom keys. This will prevent the loading state of the various thread setting from being shared across different threads. Here is an example with the edit thread color setting
Details
Details
Tested all four loaders that suffered from the shared loaders and after making these changes the loading state is no longer shared across different states
Name:
Description:
Color:
Leave Thread:
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Not clear why this is being prioritized right now when avatars work is so very deeply behind.
Can you please clarify how much more non-avatars work you are planning to sequence before finishing the avatars work?
| native/chat/settings/color-selector-modal.react.js | ||
|---|---|---|
| 98 ↗ | (On Diff #25621) | Please keep all lines to 80 chars |
| native/chat/settings/thread-settings-description.react.js | ||
| 214 ↗ | (On Diff #25621) | Please keep all lines to 80 chars |
| 296–301 ↗ | (On Diff #25621) |
|
| native/chat/settings/thread-settings.react.js | ||
| 1187–1220 ↗ | (On Diff #25621) | This can all be inside a single useSelector invocation Try rewriting all of this as const somethingIsSaving = useSelector(...); |
Comment Actions
Not clear why this is being prioritized right now when avatars work is so very deeply behind.
I was under the impression that we should fix this foundational piece first so that the loading state when saving a thread avatar would not be shared across different threads. If we should completely deprioritize this right now lmk
Can you please clarify how much more non-avatars work you are planning to sequence before finishing the avatars work?
This is the last diff that is considered "non avatars work"