Page MenuHomePhabricator
Differential D7603

[native] Introduce `recursivelyUpdateCurrentMemberPermissions(...)`
ClosedPublic
Actions

Authored by atul on Apr 25 2023, 1:46 AM.
Tags
None
Referenced Files
F2208113: D7603.id25648.diff
Sun, Jul 7, 11:52 AM
Unknown Object (File)
Fri, Jul 5, 3:14 PM
Unknown Object (File)
Tue, Jul 2, 9:11 PM
Unknown Object (File)
Tue, Jul 2, 9:55 AM
Unknown Object (File)
Tue, Jul 2, 5:02 AM
Unknown Object (File)
Sun, Jun 30, 10:39 AM
Unknown Object (File)
Thu, Jun 27, 11:24 PM
Unknown Object (File)
Thu, Jun 27, 6:53 PM
View All 38 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM73d25bc2db2e: [native] Introduce `recursivelyUpdateCurrentMemberPermissions(...)`
Summary

We introduce recursivelyUpdateCurrentMemberPermissions(...) which traverses node and all children recursively to update threadInfo.currentUser.permissions.

Very similar to D7602 but handles currentUser.permissions isntead of member.permissions

Depends on D7602

Test Plan

Ran with correct threadStore and ensured that it remained the same.

Added a unit test to ensure that currentUser.permissions could be "constructed from scratch" (without depending on any existing currentUser.permissions

Similar to D7602 ran into some issues with my prod thread store. Specifically threadID: 892819 and roleID: 89280, hoping I can sync w/ @ashoat in the office tomorrow to troubleshoot since I don't have access to prod DB.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 25 2023, 1:46 AM
Herald added a subscriber: tomek. · View Herald TranscriptApr 25 2023, 1:46 AM
Harbormaster completed remote builds in B18726: Diff 25648.Apr 25 2023, 2:03 AM
atul requested review of this revision.Apr 25 2023, 2:03 AM
ashoat accepted this revision.Apr 25 2023, 4:10 AM
ashoat added inline comments.
native/redux/update-roles-and-permissions.js
146–148 ↗(On Diff #25648)

Can we make these all forEach?

This revision is now accepted and ready to land.Apr 25 2023, 4:10 AM
atul updated this revision to Diff 25707.Apr 25 2023, 12:59 PM

address merge conflicts

This revision was landed with ongoing or failed builds.Apr 25 2023, 1:02 PM
Closed by commit rCOMM73d25bc2db2e: [native] Introduce `recursivelyUpdateCurrentMemberPermissions(...)` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM73d25bc2db2e: [native] Introduce `recursivelyUpdateCurrentMemberPermissions(...)`.
Harbormaster completed remote builds in B18763: Diff 25707.Apr 25 2023, 1:18 PM

Revision Contents
Changeset List

Diff 25708

View Options

native/redux/update-roles-and-permissions-test-data.js

Loading...
View Options

native/redux/update-roles-and-permissions.js

Loading...
View Options

native/redux/update-roles-and-permissions.test.js

Loading...