Paths

Table of Contentst

Differential D7640

[web] turn off dummy avatar feature flag
ClosedPublic
Actions

Authored by ginsu on Apr 26 2023, 4:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 9:03 PM

	Unknown Object (File)
	Sun, Jan 5, 9:03 PM

	Unknown Object (File)
	Sun, Jan 5, 9:03 PM

	Unknown Object (File)
	Sun, Jan 5, 9:03 PM

	Unknown Object (File)
	Sun, Jan 5, 8:59 PM

	Unknown Object (File)
	Wed, Dec 11, 6:40 AM

	Unknown Object (File)
	Mon, Dec 9, 10:39 PM

	Unknown Object (File)
	Nov 25 2024, 8:44 PM

View All 83 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM7816aae2fb74: [web] turn off dummy avatar feature flag

Summary

flip off avatar feature flag so that avatars now render on web. In ENG-3413 we consider removing and deprecating the feature flag rendering logic throughout our codebase which would be useful to do in the future since this flag is now always hardcoded to true

Depends on D7639

Test Plan

avatars now render on web

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 26 2023, 4:32 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 26 2023, 4:32 PM

ginsu edited the summary of this revision. (Show Details)Apr 26 2023, 4:44 PM

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7639: [web] fix image avatar image being stretched.

ginsu edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B18827: Diff 25795.Apr 26 2023, 4:49 PM

ginsu requested review of this revision.Apr 26 2023, 4:49 PM

ashoat accepted this revision.Apr 27 2023, 10:16 AM

This revision is now accepted and ready to land.Apr 27 2023, 10:16 AM

rebase before landing

Harbormaster completed remote builds in B18893: Diff 25879.Apr 27 2023, 11:38 AM

Closed by commit rCOMM7816aae2fb74: [web] turn off dummy avatar feature flag (authored by ginsu). · Explain WhyApr 27 2023, 12:34 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7816aae2fb74: [web] turn off dummy avatar feature flag.

Revision Contents
Changeset List

Path

Size

web/

utils/

avatar-utils.js

2 lines

Diff 25885

web/utils/avatar-utils.js

Loading...