Saw this in yarn cleaninstall logs:
Doesn't make sense to exit 1 if not on Windows because it's not an error. Doesn't really matter, but quick fix.
Differential D7675
[desktop] Have `preinstall` fail silently if not on Windows atul on Apr 27 2023, 12:29 PM. Authored by Tags None Referenced Files
Details
Diff Detail
Event TimelineComment Actions I've just tried this code and during yarn cleaninstall I'm getting an error with node-gyp rebuild (which makes sense because it tries to use things from nuget dependencies which aren't downloaded on macOS). @atul are you also getting this error? Either command fail is "fine" because this whole package is marked as optional so if anything fails during installation it won't be included on macOS (which is the behavior we want). Personally, I think that exiting early with exit 1 is cleaner than letting node-gyp fail with an arcane error. The best solution would be to make a dummy node-gyp config for this package for macOS so that it can be built correctly, but I had some problems with that and didn't have much time. I would like to handle this during the bugbash. |