[native] Bump expo and expo-image
ClosedPublic
Actions

Authored by bartek on May 8 2023, 11:28 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM55fa3c0758cc: [native] Bump expo and expo-image

Summary

Resolves ENG-3752. Bumped expo-image to 1.2.0 - version that supports thumbhash. This also required bumping expo package in order to bump its dependency expo-modules-core to 1.1.1.

Test Plan

Built both iOS and Android. Played around - photo messages and avatars are still displayed correctly. Added dummy placeholder={{ thumbhash }} prop to Image component to ensure thumbhash works.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.May 8 2023, 11:28 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 8 2023, 11:28 PM

Harbormaster completed remote builds in B19159: Diff 26239.May 8 2023, 11:47 PM

bartek requested review of this revision.May 8 2023, 11:47 PM

Changes look good, adding @ashoat as blocking (as formality) since it's a dependency diff.

native/expo-modules/aes-crypto/package.json
10	Think we typically prefix dependencies w/ `^`. Is there a reason we should be explicit here about specifying version instead of range?

bartek added inline comments.May 9 2023, 3:43 AM

native/expo-modules/aes-crypto/package.json
10	I had a strange issue where yarn was resolving this to the wrong version and caused duplicated version in the lockfile. In case of expo-modules, explicit version is not a big deal as long as it matches the resolved version of the app's dependency (`app` -> `expo` -> `expo-modules-core`). I can try with range version to see if it resolves correctly

bartek added inline comments.May 9 2023, 5:35 AM

native/expo-modules/aes-crypto/package.json
10	The `~` operator works as expected... But, the `expo` package uses a strict version here: https://github.com/expo/expo/blob/8147ccf57bd0f7135f9ed1503cad695d43f9a702/packages/expo/package.json#L75