[native] Make SIWEPanel more generic
ClosedPublic
Actions

Authored by ashoat on May 16 2023, 6:22 AM.

Details

Reviewers

ginsu
atul

Commits

rCOMMa3a99101985b: [native] Make SIWEPanel more generic

Summary

This way we can use it from the new registration flow as well.

Test Plan

Read the code and make sure that the only valid value of nextMode after siwe is prompt
Flow
Make sure the old SIWE flow still works correctly, and that all of the ways to close it (swipe away SIWEPanel, hit back button, and hit close button) all still work and animate correctly

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 16 2023, 6:22 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 16 2023, 6:22 AM

Harbormaster completed remote builds in B19396: Diff 26539.May 16 2023, 6:43 AM

ashoat requested review of this revision.May 16 2023, 6:43 AM

ashoat added a child revision: D7841: [native] Factor out loading spinner from SIWEPanel.May 16 2023, 6:58 AM

atul accepted this revision.May 16 2023, 9:26 AM

This revision is now accepted and ready to land.May 16 2023, 9:26 AM

Closed by commit rCOMMa3a99101985b: [native] Make SIWEPanel more generic (authored by ashoat). · Explain WhyMay 16 2023, 12:01 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa3a99101985b: [native] Make SIWEPanel more generic.

Revision Contents
Changeset List

Path

Size

native/

account/

logged-out-modal.react.js

2 lines

siwe-panel.react.js

13 lines

Diff 26559

View Options

native/account/logged-out-modal.react.js

Show All 38 Lines	.menuContent {
background-color: #eeeeee;		background-color: #eeeeee;
border-radius: 5px;		border-radius: 5px;
box-shadow: 1px 1px 5px 2px #00000022;		box-shadow: 1px 1px 5px 2px #00000022;
}		}
.menuContentVisible {		.menuContentVisible {
display: block;		display: block;
}		}

		.menuSidebar {
		padding-right: 2px;
		}

button.menuContent {		button.menuContent {
border: none;		border: none;
cursor: pointer;		cursor: pointer;
padding: 10px;		padding: 10px;
font-size: 16px;		font-size: 16px;
}		}
button.menuContent:hover {		button.menuContent:hover {
background-color: #dddddd;		background-color: #dddddd;
}		}