Page MenuHomePhabricator
Differential D7857

Introduce initial notifications encrypted message getter to socket selectors
AbandonedPublicDraft
Actions

Authored by marcin on May 18 2023, 4:47 AM.
Tags
None
Referenced Files
F5930590: D7857.diff
Fri, Apr 18, 3:51 AM
Unknown Object (File)
Mon, Apr 14, 5:27 PM
Unknown Object (File)
Wed, Apr 9, 1:04 AM
Unknown Object (File)
Tue, Apr 8, 11:25 PM
Unknown Object (File)
Tue, Apr 8, 11:02 PM
Unknown Object (File)
Tue, Apr 8, 10:38 PM
Unknown Object (File)
Mar 10 2025, 2:49 PM
Unknown Object (File)
Mar 9 2025, 9:58 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
atul
bartek
Summary

This differential adds methods to get initial notifications encrypted message to socket selectors

Test Plan

Run flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.May 18 2023, 4:47 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 18 2023, 4:47 AM
Harbormaster returned this revision to the author for changes because remote builds failed.May 18 2023, 5:01 AM
Harbormaster failed remote builds in B19459: Diff 26624!
marcin added a parent revision: D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.May 18 2023, 5:03 AM
marcin added a child revision: D7858: Add initial notifications encrypted message generator to client responses selector on native.
marcin updated this revision to Diff 26632.May 18 2023, 5:47 AM

Squash and rebase

marcin abandoned this revision.May 18 2023, 5:50 AM
marcin removed a parent revision: D7856: Add request and response types for the keyserver to request first encrypted message for e2e notifs.
marcin removed a child revision: D7858: Add initial notifications encrypted message generator to client responses selector on native.
Harbormaster completed remote builds in B19467: Diff 26632.May 18 2023, 6:05 AM
marcin updated this revision to Diff 27177.May 29 2023, 11:38 AM

Rebase before landing

marcin abandoned this revision.May 29 2023, 11:52 AM

I am not sure how this happened that this differential was created. I was doing an arc diff on squashed commit.

Harbormaster completed remote builds in B19846: Diff 27177.May 29 2023, 12:14 PM

Revision Contents
Changeset List

PathSize
lib/
selectors/
13 lines
native/
selectors/
18 lines
6 lines
web/
selectors/
2 lines

Diff 27177

View Options

lib/selectors/socket-selectors.js

#!/usr/bin/env bash #!/usr/bin/env bash
set -e set -e
# Allow scripts to be called from anywhere # Allow scripts to be called from anywhere
SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P) SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P)
# folly hack - https://github.com/facebook/folly/pull/1231 # folly hack - https://github.com/facebook/folly/pull/1231
if [[ -f /usr/lib/folly/folly/detail/Demangle.h ]]; then
# Legacy path-centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/lib/folly/folly/detail/Demangle.h
rm -rf lib
mkdir lib
pushd lib
ln -s /usr/lib/folly .
ln -s /usr/lib/glog .
ln -s /usr/lib/double-conversion .
popd # lib
rm -rf _generated
mkdir _generated
"${SCRIPT_DIR}"/proto_codegen.sh
else
# New installation centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \ sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/local/include/folly/detail/Demangle.h /usr/local/include/folly/detail/Demangle.h
fi
rm -rf cmake/build rm -rf cmake/build
mkdir -p cmake/build mkdir -p cmake/build
"${SCRIPT_DIR}"/build_sources.sh "${SCRIPT_DIR}"/build_sources.sh
View Options

native/selectors/socket-selectors.js

#!/usr/bin/env bash #!/usr/bin/env bash
set -e set -e
# Allow scripts to be called from anywhere # Allow scripts to be called from anywhere
SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P) SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P)
# folly hack - https://github.com/facebook/folly/pull/1231 # folly hack - https://github.com/facebook/folly/pull/1231
if [[ -f /usr/lib/folly/folly/detail/Demangle.h ]]; then
# Legacy path-centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/lib/folly/folly/detail/Demangle.h
rm -rf lib
mkdir lib
pushd lib
ln -s /usr/lib/folly .
ln -s /usr/lib/glog .
ln -s /usr/lib/double-conversion .
popd # lib
rm -rf _generated
mkdir _generated
"${SCRIPT_DIR}"/proto_codegen.sh
else
# New installation centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \ sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/local/include/folly/detail/Demangle.h /usr/local/include/folly/detail/Demangle.h
fi
rm -rf cmake/build rm -rf cmake/build
mkdir -p cmake/build mkdir -p cmake/build
"${SCRIPT_DIR}"/build_sources.sh "${SCRIPT_DIR}"/build_sources.sh
View Options

native/socket.react.js

#!/usr/bin/env bash #!/usr/bin/env bash
set -e set -e
# Allow scripts to be called from anywhere # Allow scripts to be called from anywhere
SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P) SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P)
# folly hack - https://github.com/facebook/folly/pull/1231 # folly hack - https://github.com/facebook/folly/pull/1231
if [[ -f /usr/lib/folly/folly/detail/Demangle.h ]]; then
# Legacy path-centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/lib/folly/folly/detail/Demangle.h
rm -rf lib
mkdir lib
pushd lib
ln -s /usr/lib/folly .
ln -s /usr/lib/glog .
ln -s /usr/lib/double-conversion .
popd # lib
rm -rf _generated
mkdir _generated
"${SCRIPT_DIR}"/proto_codegen.sh
else
# New installation centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \ sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/local/include/folly/detail/Demangle.h /usr/local/include/folly/detail/Demangle.h
fi
rm -rf cmake/build rm -rf cmake/build
mkdir -p cmake/build mkdir -p cmake/build
"${SCRIPT_DIR}"/build_sources.sh "${SCRIPT_DIR}"/build_sources.sh
View Options

web/selectors/socket-selectors.js

#!/usr/bin/env bash #!/usr/bin/env bash
set -e set -e
# Allow scripts to be called from anywhere # Allow scripts to be called from anywhere
SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P) SCRIPT_DIR=$(cd "$(dirname "$0")"; pwd -P)
# folly hack - https://github.com/facebook/folly/pull/1231 # folly hack - https://github.com/facebook/folly/pull/1231
if [[ -f /usr/lib/folly/folly/detail/Demangle.h ]]; then
# Legacy path-centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/lib/folly/folly/detail/Demangle.h
rm -rf lib
mkdir lib
pushd lib
ln -s /usr/lib/folly .
ln -s /usr/lib/glog .
ln -s /usr/lib/double-conversion .
popd # lib
rm -rf _generated
mkdir _generated
"${SCRIPT_DIR}"/proto_codegen.sh
else
# New installation centric workflow
sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \ sed -i 's/#if __has_include(<demangle.h>)/#if __has_include(<Demangle.h>)/g' \
/usr/local/include/folly/detail/Demangle.h /usr/local/include/folly/detail/Demangle.h
fi
rm -rf cmake/build rm -rf cmake/build
mkdir -p cmake/build mkdir -p cmake/build
"${SCRIPT_DIR}"/build_sources.sh "${SCRIPT_DIR}"/build_sources.sh