Page MenuHomePhabricator

[native] Update panelSecondaryForeground to shadesBlack80
ClosedPublic

Authored by ashoat on May 19 2023, 10:57 AM.
Tags
None
Referenced Files
F1696000: D7887.diff
Fri, May 3, 11:58 AM
Unknown Object (File)
Sun, Apr 28, 3:50 PM
Unknown Object (File)
Wed, Apr 24, 1:35 PM
Unknown Object (File)
Mon, Apr 22, 11:18 AM
Unknown Object (File)
Mon, Apr 22, 11:18 AM
Unknown Object (File)
Mon, Apr 22, 11:18 AM
Unknown Object (File)
Mon, Apr 22, 11:15 AM
Unknown Object (File)
Feb 24 2024, 1:10 AM
Subscribers

Details

Summary

In the previous diff, I was implementing a design where the walletIdentifierTile (panel foreground) had a tile inside it. I figured that inner tile should logically use the "panel secondary foreground" color.

However, panelSecondaryForeground was currently set to #333333, which does not appear in our design system, and did not match the designs for the inner tile.

This diff updates panelSecondaryForeground to match the designs for the inner tile, and makes sure it's now using a color from the design system. The only other place that is impacted is the calendar tab.

Test Plan
beforeafter
registration
Screenshot 2023-05-19 at 1.51.43 PM.png (2×1 px, 830 KB)
Screenshot 2023-05-19 at 1.52.56 PM.png (2×1 px, 831 KB)
calendar
Screenshot 2023-05-19 at 1.54.07 PM.png (2×1 px, 899 KB)
Screenshot 2023-05-19 at 1.53.33 PM.png (2×1 px, 896 KB)

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage