Page MenuHomePhabricator
Differential D7886

[native] Add wallet identifier tile to ExistingEthereumAccount
ClosedPublic
Actions

Authored by ashoat on May 19 2023, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 2:39 AM
Unknown Object (File)
Wed, Mar 12, 10:01 PM
Unknown Object (File)
Sat, Mar 1, 9:37 AM
Unknown Object (File)
Sat, Mar 1, 9:37 AM
Unknown Object (File)
Sat, Mar 1, 9:35 AM
Unknown Object (File)
Sat, Mar 1, 9:23 AM
Unknown Object (File)
Feb 20 2025, 4:35 AM
Unknown Object (File)
Feb 17 2025, 10:15 PM
View All 89 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount
Summary

See designs here (for ENS name) and here (for wallet address).

To make it easier to access the wallet address, I also added that to ExistingEthereumAccountParams.

Depends on D7882

Test Plan
ENS nameWallet address
Screenshot 2023-05-19 at 1.35.24 PM.png (2×1 px, 831 KB)
Screenshot 2023-05-19 at 1.35.23 PM.png (2×1 px, 837 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.May 19 2023, 10:39 AM
Herald added a subscriber: tomek. · View Herald TranscriptMay 19 2023, 10:39 AM
ashoat edited the test plan for this revision. (Show Details)May 19 2023, 10:40 AM
ashoat added inline comments.
native/account/registration/existing-ethereum-account.react.js
60 ↗(On Diff #26689)

Snuck this copy change in. I think it looks better when it's more concise

ashoat added a child revision: D7887: [native] Update panelSecondaryForeground to shadesBlack80.May 19 2023, 10:57 AM
Harbormaster completed remote builds in B19522: Diff 26689.May 19 2023, 10:57 AM
ashoat requested review of this revision.May 19 2023, 10:57 AM
atul accepted this revision.May 19 2023, 11:29 AM
This revision is now accepted and ready to land.May 19 2023, 11:29 AM
Closed by commit rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount (authored by ashoat). · Explain WhyMay 19 2023, 12:56 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
3 lines
53 lines

Diff 26706

View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/registration/existing-ethereum-account.react.js

Loading...