Page MenuHomePhabricator

[native] Add wallet identifier tile to ExistingEthereumAccount
ClosedPublic

Authored by ashoat on May 19 2023, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 24 2024, 1:10 AM
Unknown Object (File)
Feb 23 2024, 11:50 PM
Unknown Object (File)
Feb 23 2024, 11:47 PM
Unknown Object (File)
Feb 23 2024, 10:49 PM
Unknown Object (File)
Jan 11 2024, 7:47 AM
Unknown Object (File)
Dec 21 2023, 2:14 AM
Unknown Object (File)
Dec 16 2023, 11:10 PM
Unknown Object (File)
Nov 23 2023, 7:27 AM
Subscribers

Details

Summary

See designs here (for ENS name) and here (for wallet address).

To make it easier to access the wallet address, I also added that to ExistingEthereumAccountParams.

Depends on D7882

Test Plan
ENS nameWallet address
Screenshot 2023-05-19 at 1.35.24 PM.png (2×1 px, 831 KB)
Screenshot 2023-05-19 at 1.35.23 PM.png (2×1 px, 837 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat added inline comments.
native/account/registration/existing-ethereum-account.react.js
60 ↗(On Diff #26689)

Snuck this copy change in. I think it looks better when it's more concise

This revision is now accepted and ready to land.May 19 2023, 11:29 AM