Paths

Table of Contentst

[native] Add wallet identifier tile to ExistingEthereumAccount
ClosedPublic
Actions

Authored by ashoat on May 19 2023, 10:39 AM.

Details

Reviewers

atul
ginsu

Commits

rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount

Summary

See designs here (for ENS name) and here (for wallet address).

To make it easier to access the wallet address, I also added that to ExistingEthereumAccountParams.

Depends on D7882

Test Plan

ENS name	Wallet address

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/registration

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 19 2023, 10:39 AM

Herald added a subscriber: tomek. · View Herald TranscriptMay 19 2023, 10:39 AM

ashoat edited the test plan for this revision. (Show Details)May 19 2023, 10:40 AM

ashoat added inline comments.

native/account/registration/existing-ethereum-account.react.js
60	Snuck this copy change in. I think it looks better when it's more concise

ashoat added a child revision: D7887: [native] Update panelSecondaryForeground to shadesBlack80.May 19 2023, 10:57 AM

Harbormaster completed remote builds in B19522: Diff 26689.May 19 2023, 10:57 AM

ashoat requested review of this revision.May 19 2023, 10:57 AM

atul accepted this revision.May 19 2023, 11:29 AM

This revision is now accepted and ready to land.May 19 2023, 11:29 AM

Closed by commit rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount (authored by ashoat). · Explain WhyMay 19 2023, 12:56 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1f14b3067b31: [native] Add wallet identifier tile to ExistingEthereumAccount.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

connect-ethereum.react.js

3 lines

existing-ethereum-account.react.js

53 lines

Diff 26689

View Options

native/account/registration/connect-ethereum.react.js