Page MenuHomePhabricator
Differential D7892

[web] Increase `font-size` of `formNotice` in `CommunityCreationModal`
ClosedPublic
Actions

Authored by atul on May 19 2023, 12:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 13, 11:04 AM
Unknown Object (File)
Sun, Apr 13, 9:54 AM
Unknown Object (File)
Sun, Apr 13, 12:40 AM
Unknown Object (File)
Sat, Apr 12, 3:28 PM
Unknown Object (File)
Wed, Apr 9, 10:44 AM
Unknown Object (File)
Sat, Mar 29, 12:37 AM
Unknown Object (File)
Mar 21 2025, 6:15 AM
Unknown Object (File)
Mar 1 2025, 10:09 AM
View All 95 Files
Subscribers
tomek

Details

Reviewers
ashoat
• ted
Commits
rCOMMb003298adfc8: [web] Increase `font-size` of `formNotice` in `CommunityCreationModal`
Summary

I think this is more readable. It was previously too small IMO.

This matches the font-size in Figma. Previously reduced from 12px to 10px so the text would fit on one line as in the designs. However, now that we have the CommunityCreationModal "size" set to "large" we can fit things fine.

Test Plan

Before:

Screenshot 2023-05-19 at 2.57.45 PM.png (1×2 px, 307 KB)

After:

Screenshot 2023-05-19 at 2.57.27 PM.png (1×2 px, 305 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
sidebar/
community-creation/
2 lines

Diff 26697

View Options

web/sidebar/community-creation/community-creation-modal.css

Show First 20 Lines • Show All 148 Lines • ▼ Show 20 Lines render(): React.Node {
const textInputs = []; const textInputs = [];
if (this.state.textInputKey > 0) { if (this.state.textInputKey > 0) {
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
style={[props.style, styles.invisibleTextInput]} style={[props.style, styles.invisibleTextInput]}
onChangeText={this.onOldInputChangeText} onChangeText={this.onOldInputChangeText}
onSelectionChange={this.props.onSelectionChange}
onKeyPress={this.onOldInputKeyPress} onKeyPress={this.onOldInputKeyPress}
onBlur={this.onOldInputBlur} onBlur={this.onOldInputBlur}
onFocus={this.onOldInputFocus} onFocus={this.onOldInputFocus}
key={this.state.textInputKey - 1} key={this.state.textInputKey - 1}
/>, />,
); );
} }
textInputs.push( textInputs.push(
<TextInput <TextInput
{...props} {...props}
onFocus={this.onFocus} onFocus={this.onFocus}
onBlur={this.onBlur} onBlur={this.onBlur}
onChangeText={this.props.onChangeText} onChangeText={this.props.onChangeText}
onSelectionChange={this.props.onSelectionChange}
key={this.state.textInputKey} key={this.state.textInputKey}
ref={this.textInputRef} ref={this.textInputRef}
/>, />,
); );
return <View style={styles.textInputContainer}>{textInputs}</View>; return <View style={styles.textInputContainer}>{textInputs}</View>;
} }
} }
Show All 12 Lines