Page MenuHomePhabricator
Differential D7897

Update &apos to &rsquo
ClosedPublic
Actions

Authored by ashoat on May 20 2023, 5:31 AM.
Tags
None
Referenced Files
F4948550: D7897.diff
Wed, Mar 19, 9:58 PM
Unknown Object (File)
Mon, Mar 17, 6:43 PM
Unknown Object (File)
Thu, Mar 6, 12:25 PM
Unknown Object (File)
Thu, Mar 6, 12:25 PM
Unknown Object (File)
Thu, Mar 6, 12:25 PM
Unknown Object (File)
Wed, Mar 5, 12:57 PM
Unknown Object (File)
Tue, Mar 4, 5:14 AM
Unknown Object (File)
Sat, Mar 1, 11:31 PM
View All 98 Files
Subscribers
atul
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM07a58f582044: Update &apos to &rsquo
Summary

In D7893, @atul pointed out that &apos is actually the ASCII single-quote character ('), while &rsquo is the Unicode character preferred for apostrophes. I did some Googling and found this resource, which supports the idea that the right-side quote character is the preferred Unicode character for apostrophe usage.

Test Plan

I made sure that the character looked better on one of the screens (ConnectEthereum). For the rest, I'm relying on careful reading

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 26799

View Options

landing/keyservers.react.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

landing/privacy.react.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

landing/qr.react.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

landing/terms.react.js

// @flow // @flow
import Clipboard from '@react-native-clipboard/clipboard'; import Clipboard from '@react-native-clipboard/clipboard';
import * as React from 'react'; import * as React from 'react';
import { Text, View } from 'react-native'; import { Text, View } from 'react-native';
import { TouchableOpacity } from 'react-native-gesture-handler'; import { TouchableOpacity } from 'react-native-gesture-handler';
import { inviteLinkUrl } from 'lib/facts/links.js'; import { inviteLinkURL } from 'lib/facts/links.js';
import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js'; import { primaryInviteLinksSelector } from 'lib/selectors/invite-links-selectors.js';
import { threadHasPermission } from 'lib/shared/thread-utils.js'; import { threadHasPermission } from 'lib/shared/thread-utils.js';
import type { InviteLink } from 'lib/types/link-types.js'; import type { InviteLink } from 'lib/types/link-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import SingleLine from '../components/single-line.react.js'; import SingleLine from '../components/single-line.react.js';
import SWMansionIcon from '../components/swmansion-icon.react.js'; import SWMansionIcon from '../components/swmansion-icon.react.js';
Show All 20 Lines
function ViewInviteLinksScreen(props: Props): React.Node { function ViewInviteLinksScreen(props: Props): React.Node {
const { community } = props.route.params; const { community } = props.route.params;
const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[ const inviteLink: ?InviteLink = useSelector(primaryInviteLinksSelector)[
community.id community.id
]; ];
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const { modalForegroundLabel } = useColors(); const { modalForegroundLabel } = useColors();
const linkUrl = inviteLinkUrl(inviteLink?.name ?? ''); const linkUrl = inviteLinkURL(inviteLink?.name ?? '');
const onPressCopy = React.useCallback(() => { const onPressCopy = React.useCallback(() => {
Clipboard.setString(linkUrl); Clipboard.setString(linkUrl);
setTimeout(confirmCopy); setTimeout(confirmCopy);
}, [linkUrl]); }, [linkUrl]);
const { navigate } = props.navigation; const { navigate } = props.navigation;
const onEditButtonClick = React.useCallback(() => { const onEditButtonClick = React.useCallback(() => {
navigate<'ManagePublicLink'>({ navigate<'ManagePublicLink'>({
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

native/account/registration/connect-ethereum.react.js

Loading...
View Options

native/account/terms-and-privacy-modal.react.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/crash.react.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...
View Options

web/modals/chat/invalid-upload.react.js

Loading...
View Options

web/modals/terms-and-privacy-modal.react.js

Loading...