Page MenuHomePhabricator
Differential D7893

[web] Replace `'` with `'` in `announcementStatements`
ClosedPublic
Actions

Authored by atul on Fri, May 19, 12:04 PM.
Tags
None
Referenced Files
F570554: D7893.id26797.diff
Sat, Jun 3, 9:28 AM
Unknown Object (File)
Fri, Jun 2, 12:48 AM
Unknown Object (File)
Mon, May 29, 4:20 AM
Unknown Object (File)
Fri, May 19, 1:09 PM
F546477: Screenshot 2023-05-19 at 3.56.14 PM.png
Fri, May 19, 12:56 PM
F546427: 3866d5.png
Fri, May 19, 12:20 PM
F546398: 95b507.png
Fri, May 19, 12:05 PM
F546397: 9c9f58.png
Fri, May 19, 12:05 PM
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM40d1dbb3c8b9: [web] Replace `'` with `'` in `announcementStatements`
Summary

' was appearing on the page instead of an apostrophe. I'm guessing there's some sort of sanitization step that's escaping '?

Test Plan

Before:

9c9f58.png (1×1 px, 117 KB)

After:

95b507.png (1×1 px, 113 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Fri, May 19, 12:04 PM
Herald added a subscriber: tomek. · View Herald TranscriptFri, May 19, 12:04 PM
atul published this revision for review.Fri, May 19, 12:05 PM
atul edited the test plan for this revision. (Show Details)
ashoat requested changes to this revision.Fri, May 19, 12:07 PM

The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use ’

This revision now requires changes to proceed.Fri, May 19, 12:07 PM
atul updated this revision to Diff 26700.Fri, May 19, 12:09 PM

’ instead of '

ashoat accepted this revision.Fri, May 19, 12:18 PM
This revision is now accepted and ready to land.Fri, May 19, 12:18 PM
atul added a comment.EditedFri, May 19, 12:20 PM
In D7893#233851, @ashoat wrote:

The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use ’

I believe ' is a straight quote. I think you might have meant ’?

3866d5.png (1×1 px, 146 KB)

Can see in the highlighted chunk that ' results in a straight quote and below in the announcement text ’ results in a "curly" (or angled) quote.

Harbormaster completed remote builds in B19530: Diff 26698.Fri, May 19, 12:22 PM
Harbormaster completed remote builds in B19531: Diff 26700.Fri, May 19, 12:27 PM
ashoat added a comment.EditedFri, May 19, 12:56 PM

Ah dang, good thing ' didn't work...

I'm not sure about ’... I think that's the character for closing a single quotation, but then again I can't see any visual difference here:

Screenshot 2023-05-19 at 3.56.14 PM.png (42×540 px, 24 KB)

EDIT

Ah yeah looks like ’ is correct: https://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html

ashoat mentioned this in D7897: Update &apos to &rsquo.Sat, May 20, 5:31 AM
ashoat added inline comments.Sat, May 20, 5:38 AM
web/sidebar/community-creation/community-creation-modal.react.js
179 ↗(On Diff #26700)

Can you also update this &apos to an &rsquo?

(Alternately if you prefer I can add it to D7897)

atul updated this revision to Diff 26797.Mon, May 22, 7:29 AM

apos to rquote

This revision was landed with ongoing or failed builds.Mon, May 22, 7:42 AM
Closed by commit rCOMM40d1dbb3c8b9: [web] Replace `'` with `'` in `announcementStatements` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM40d1dbb3c8b9: [web] Replace `'` with `'` in `announcementStatements`.
Harbormaster completed remote builds in B19606: Diff 26797.Mon, May 22, 7:47 AM
ashoat mentioned this in rCOMM07a58f582044: Update &apos to &rsquo.Mon, May 22, 8:03 AM

Revision Contents
Changeset List

PathSize
web/
sidebar/
community-creation/
4 lines

Diff 26798

View Options

web/sidebar/community-creation/community-creation-modal.react.js

Loading...