Page MenuHomePhabricator

[web] Replace `'` with `'` in `announcementStatements`
ClosedPublic

Authored by atul on May 19 2023, 12:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 8:33 PM
Unknown Object (File)
Thu, Apr 4, 11:00 PM
Unknown Object (File)
Wed, Apr 3, 4:17 PM
Unknown Object (File)
Wed, Apr 3, 4:17 PM
Unknown Object (File)
Wed, Apr 3, 4:17 PM
Unknown Object (File)
Wed, Apr 3, 4:17 PM
Unknown Object (File)
Wed, Apr 3, 4:13 PM
Unknown Object (File)
Feb 20 2024, 7:06 AM
Subscribers

Details

Summary

' was appearing on the page instead of an apostrophe. I'm guessing there's some sort of sanitization step that's escaping '?

Test Plan

Before:

9c9f58.png (1×1 px, 117 KB)

After:

95b507.png (1×1 px, 113 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul published this revision for review.May 19 2023, 12:05 PM
atul edited the test plan for this revision. (Show Details)
ashoat requested changes to this revision.May 19 2023, 12:07 PM

The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use

This revision now requires changes to proceed.May 19 2023, 12:07 PM
This revision is now accepted and ready to land.May 19 2023, 12:18 PM

The whole point of using ' is so that we're using the apostrophe character, not the single-quote character. Please use

I believe ' is a straight quote. I think you might have meant ’?

3866d5.png (1×1 px, 146 KB)

Can see in the highlighted chunk that ' results in a straight quote and below in the announcement text results in a "curly" (or angled) quote.

Ah dang, good thing ' didn't work...

I'm not sure about ’... I think that's the character for closing a single quotation, but then again I can't see any visual difference here:

Screenshot 2023-05-19 at 3.56.14 PM.png (42×540 px, 24 KB)

EDIT

Ah yeah looks like ’ is correct: https://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html

web/sidebar/community-creation/community-creation-modal.react.js
179 ↗(On Diff #26700)

Can you also update this &apos to an &rsquo?

(Alternately if you prefer I can add it to D7897)

This revision was landed with ongoing or failed builds.May 22 2023, 7:42 AM
This revision was automatically updated to reflect the committed changes.