Page MenuHomePhabricator
Differential D8003

[native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on Android
ClosedPublic
Actions

Authored by ashoat on May 26 2023, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 4, 9:34 PM
Unknown Object (File)
Thu, Apr 4, 9:34 PM
Unknown Object (File)
Thu, Apr 4, 9:33 PM
Unknown Object (File)
Thu, Apr 4, 9:29 PM
Unknown Object (File)
Thu, Mar 28, 2:43 PM
Unknown Object (File)
Feb 20 2024, 11:30 PM
Unknown Object (File)
Feb 20 2024, 10:55 PM
Unknown Object (File)
Feb 20 2024, 8:25 PM
View All 24 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM98a1caa65c72: [native] Prevent CoolOrNerdModeSelection emojis from rendering with opacity on…
Summary

I noticed that the emojis in the CoolOrNerdModeSelection screen were kind of blurry. I did some Googling and found this solution.

On iOS, setting the text color of emojis has no effect. On Android, setting the text color of emojis to black seems to make them render with full opacity.

Depends on D8002

Test Plan
beforeafter
Screenshot 2023-05-26 at 2.57.39 PM.png (1×541 px, 134 KB)
Screenshot 2023-05-26 at 2.57.25 PM.png (1×563 px, 157 KB)

Also tested on iOS to confirm no changes. Note that the registration flow only supports dark mode, but it appears that color: 'black' has the same impact on Android in either mode.

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/registration
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
account/
registration/
1 line

Diff 27106

View Options

native/account/registration/cool-or-nerd-mode-selection.react.js

Loading...