[native] Launch message editing on mobile
ClosedPublic
Actions

Authored by ashoat on May 26 2023, 1:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 19, 1:48 PM

	Unknown Object (File)
	Fri, Apr 5, 2:50 AM

	Unknown Object (File)
	Fri, Apr 5, 2:50 AM

	Unknown Object (File)
	Fri, Apr 5, 2:48 AM

	Unknown Object (File)
	Fri, Apr 5, 2:38 AM

	Unknown Object (File)
	Wed, Apr 3, 3:21 AM

	Unknown Object (File)
	Feb 20 2024, 12:31 AM

	Unknown Object (File)
	Feb 20 2024, 12:02 AM

View All 25 Files

Subscribers

• kuba

tomek

Details

Reviewers

• kuba
atul

Commits

rCOMMc09ed2789c50: [native] Launch message editing on mobile

Summary

Doing this via feature flag service carries the risk that the request times out. Until that problem is solved, figure it's safer to launch via code change.

Test Plan

Message editing has been tested by @kuba already. For this simple change, relying on Flow / ESLint

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/messageediting

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.May 26 2023, 1:03 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 26 2023, 1:03 PM

Harbormaster completed remote builds in B19801: Diff 27111.May 26 2023, 1:22 PM

ashoat requested review of this revision.May 26 2023, 1:22 PM

atul accepted this revision.May 26 2023, 1:24 PM

This revision is now accepted and ready to land.May 26 2023, 1:24 PM

Closed by commit rCOMMc09ed2789c50: [native] Launch message editing on mobile (authored by ashoat). · Explain WhyMay 26 2023, 1:25 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMc09ed2789c50: [native] Launch message editing on mobile.

Revision Contents
Changeset List

Path

Size

native/

chat/

text-message.react.js

8 lines

utils/

edit-messages-utils.js

12 lines

Diff 27111

View Options

native/chat/text-message.react.js