[web] Fix preloading blob service URIs
ClosedPublic
Actions

Authored by bartek on Jun 1 2023, 12:03 AM.

Details

Reviewers

atul
ashoat

Commits

rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs

Summary

I realized that the preloadImage and preloadMediaResource functions do not resolve Blob service URIs so preloading them would fail. This diff fixes that.

Depends on D8050

Test Plan

Called preloadMediaResource with a blob-service://XXXX URI, observed the devtools Network tab.
Before it failed with network error, now it succeeds: the request is sent to https://blob.commtechnologies.org/XXXX

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 1 2023, 12:03 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 1 2023, 12:03 AM

bartek published this revision for review.Jun 1 2023, 12:17 AM

Harbormaster completed remote builds in B19948: Diff 27336.Jun 1 2023, 12:22 AM

ashoat accepted this revision.Jun 1 2023, 7:58 AM

This revision is now accepted and ready to land.Jun 1 2023, 7:58 AM

Rebase before landing

Harbormaster completed remote builds in B20017: Diff 27436.Jun 5 2023, 12:10 AM

Closed by commit rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs (authored by bartek). · Explain WhyJun 6 2023, 1:49 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs.

Revision Contents
Changeset List

Path

Size

web/

media/

media-utils.js

11 lines

Diff 27452

View Options

web/media/media-utils.js

	Show First 20 Lines • Show All 78 Lines • ▼ Show 20 Lines
	import { relationshipBlockedInEitherDirection } from './relationship-utils';			import { relationshipBlockedInEitherDirection } from './relationship-utils';
	import threadWatcher from './thread-watcher';			import threadWatcher from './thread-watcher';

	function colorIsDark(color: string): boolean {			function colorIsDark(color: string): boolean {
	return tinycolor(`#${color}`).isDark();			return tinycolor(`#${color}`).isDark();
	}			}

	const selectedThreadColorsObj = Object.freeze({			const selectedThreadColorsObj = Object.freeze({
	a: '4B87AA',			a: '4b87aa',
	b: '5C9F5F',			b: '5c9f5f',
	c: 'B8753D',			c: 'b8753d',
	d: 'AA4B4B',			d: 'aa4b4b',
	e: '6D49AB',			e: '6d49ab',
	f: 'C85000',			f: 'c85000',
	g: '008F83',			g: '008f83',
	h: '648CAA',			h: '648caa',
	i: '57697F',			i: '57697f',
	j: '575757',			j: '575757',
	});			});

	const selectedThreadColors: $ReadOnlyArray<string> = values(			const selectedThreadColors: $ReadOnlyArray<string> = values(
	selectedThreadColorsObj,			selectedThreadColorsObj,
	);			);
	export type SelectedThreadColors = $Values<typeof selectedThreadColorsObj>;			export type SelectedThreadColors = $Values<typeof selectedThreadColorsObj>;

	▲ Show 20 Lines • Show All 1,324 Lines • Show Last 20 Lines

[web] Fix preloading blob service URIsClosedPublicActions