Paths

Table of Contentst

Differential D8051

[web] Fix preloading blob service URIs
ClosedPublic
Actions

Authored by bartek on Jun 1 2023, 7:03 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs

Summary

I realized that the preloadImage and preloadMediaResource functions do not resolve Blob service URIs so preloading them would fail. This diff fixes that.

Depends on D8050

Test Plan

Called preloadMediaResource with a blob-service://XXXX URI, observed the devtools Network tab.
Before it failed with network error, now it succeeds: the request is sent to https://blob.commtechnologies.org/XXXX

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 1 2023, 7:03 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 1 2023, 7:03 AM

bartek published this revision for review.Jun 1 2023, 7:17 AM

Harbormaster completed remote builds in B19948: Diff 27336.Jun 1 2023, 7:22 AM

ashoat accepted this revision.Jun 1 2023, 2:58 PM

This revision is now accepted and ready to land.Jun 1 2023, 2:58 PM

Rebase before landing

Harbormaster completed remote builds in B20017: Diff 27436.Jun 5 2023, 7:10 AM

Closed by commit rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs. · Explain WhyJun 6 2023, 8:49 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM38c13bfdbe53: [web] Fix preloading blob service URIs.

Revision Contents
Changeset List

Path

Size

web/

media/

11 lines

Diff 27452

web/media/media-utils.js

Loading...