[native] Introduce `CommunityCreationContentContainer` component
ClosedPublic
Actions

Authored by atul on Jun 1 2023, 1:16 PM.

Details

Reviewers

ashoat
ginsu

Commits

rCOMM3f6313aefb49: [native] Introduce `CommunityCreationContentContainer` component

Summary

This component was heavily inspired by RegistrationContentContainer.

Replaced the ScrollView in RegistrationContentContainer with a View to avoid issue with virtualized list being nested within ScrollView:

Simulator Screenshot - Fresh iPhone 13 Pro - 2023-06-01 at 15.41.20.png (2×1 px, 271 KB)

Kept all the other styling and whatnot for consistency.

As with RegistrationContentContainer, this component can probably be made more general, "added to the design system," and moved to /components in the future. Will discuss how to approach this w/ @ted when he's back.

Depends on D8056

Test Plan

Things look as they did before and the RedBox no longer appears when the screen renders.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 1 2023, 1:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 1 2023, 1:16 PM

atul edited the summary of this revision. (Show Details)Jun 1 2023, 1:21 PM

atul added a child revision: D8058: [native] Pass whether created community is `ANNOUNCEMENT` to `CommunityCreationMembers`.Jun 1 2023, 1:31 PM

atul edited the summary of this revision. (Show Details)Jun 1 2023, 1:31 PM

atul added a parent revision: D8056: [native] Barebones user selection in `CommunityCreationMembers`.

Harbormaster completed remote builds in B19962: Diff 27370.Jun 1 2023, 1:35 PM

atul requested review of this revision.Jun 1 2023, 1:35 PM

ashoat accepted this revision.Jun 1 2023, 1:41 PM

ashoat added inline comments.

native/community-creation/community-creation-content-container.react.js
10–13 ↗	(On Diff #27370)	Doesn't `ViewProps` already have `children`? I guess I did the same thing, but not clear to me if it's necessary
24–25 ↗	(On Diff #27370)	Can these two components be merged? `KeyboardAvoidingView` already forwards `ViewProps`... if you apply `backgroundStyle` and `{...rest}` there, does it render the same way?

This revision is now accepted and ready to land.Jun 1 2023, 1:41 PM

rebase before addressing feedback

addressed feedback

native/community-creation/community-creation-content-container.react.js
10–13 ↗	(On Diff #27370)	Doesn't `ViewProps` already have `children`? I was wondering about that, but just ended up copying `RegistrationContentContainer` without investigating. Just tested and looks like we can exclude `children`.
24–25 ↗	(On Diff #27370)	Yeah looks like it does, thanks for pointing that out. Updated.