Page MenuHomePhabricator

[native] Fix userInfo calculation in UserAvatar
ClosedPublic

Authored by ashoat on Jun 4 2023, 10:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 4, 11:29 PM
Unknown Object (File)
Sun, Mar 3, 9:46 PM
Unknown Object (File)
Tue, Feb 27, 5:34 AM
Unknown Object (File)
Tue, Feb 27, 5:34 AM
Unknown Object (File)
Tue, Feb 27, 5:34 AM
Unknown Object (File)
Tue, Feb 27, 5:34 AM
Unknown Object (File)
Tue, Feb 27, 5:31 AM
Unknown Object (File)
Feb 4 2024, 3:55 AM
Subscribers

Details

Summary

The previous code was passing the wrong userInfo to useENSResolvedAvatar when the userInfo prop was specified. The new code keeps the decision in one place, with only one selector.

Depends on D8086

Test Plan

Make sure we're not randomly using the anonymous user emoji from EditUserAvatar rendered with a userInfo prop

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jun 4 2023, 10:13 AM
Harbormaster failed remote builds in B20008: Diff 27425!
ashoat requested review of this revision.Jun 4 2023, 3:01 PM
This revision is now accepted and ready to land.Jun 6 2023, 7:53 AM