Page MenuHomePhabricator
Differential D8113

Refactor android notifications native and JavaScript code so that JS can register for events using native constants
ClosedPublic
Actions

Authored by marcin on Jun 6 2023, 8:51 AM.
Tags
None
Referenced Files
F3640020: D8113.diff
Sat, Jan 4, 10:11 AM
Unknown Object (File)
Mon, Dec 30, 5:28 PM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
Unknown Object (File)
Wed, Dec 25, 8:59 PM
View All Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMM28f11a71c149: Refactor android notifications native and JavaScript code so that JS can…
Summary

This differential refactors android notifications code so that JavaScript can register for native notifications events using event names exported as constants from native code instead of hardcoded strings.

Test Plan

Build the app. Ensure notifications functionalities are working correctly

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-2334
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 6 2023, 8:51 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJun 6 2023, 8:51 AM
marcin added a parent revision: D8106: Refactor CommIOSNotifications native and JavaScript code so that JavaScript registers to events using getConstants object instead of hardcoded strings.Jun 6 2023, 8:53 AM
Harbormaster completed remote builds in B20048: Diff 27476.Jun 6 2023, 9:07 AM
marcin requested review of this revision.Jun 6 2023, 9:07 AM
bartek accepted this revision.Jun 7 2023, 2:34 AM
This revision is now accepted and ready to land.Jun 7 2023, 2:34 AM
marcin updated this revision to Diff 27639.Jun 12 2023, 2:50 AM

Rebase before landing

Harbormaster failed remote builds in B20174: Diff 27639!Jun 12 2023, 2:52 AM
marcin updated this revision to Diff 27656.Jun 12 2023, 8:19 AM

Rebase before landing

Harbormaster completed remote builds in B20188: Diff 27656.Jun 12 2023, 8:35 AM
marcin updated this revision to Diff 27773.Jun 14 2023, 11:10 AM

Rebase before landing

Harbormaster completed remote builds in B20261: Diff 27773.Jun 14 2023, 11:27 AM
marcin updated this revision to Diff 27784.Jun 14 2023, 11:52 AM

Rebase before landing

Harbormaster completed remote builds in B20269: Diff 27784.Jun 14 2023, 12:14 PM
Closed by commit rCOMM28f11a71c149: Refactor android notifications native and JavaScript code so that JS can… (authored by marcin). · Explain WhyJun 14 2023, 12:17 PM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM28f11a71c149: Refactor android notifications native and JavaScript code so that JS can….

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
main/
java/
app/
comm/
android/
notifications/
11 lines
14 lines
push/
11 lines
9 lines

Diff 27773

View Options

native/android/app/src/main/java/app/comm/android/notifications/CommAndroidNotifications.java

Loading...
View Options

native/android/app/src/main/java/app/comm/android/notifications/CommAndroidNotificationsEventEmitter.java

Loading...
View Options

native/push/android.js

Loading...
View Options

native/push/push-handler.react.js

Loading...