Page MenuHomePhabricator
Differential D8130

[native] Navigate to newly created community after successful creation
ClosedPublic
Actions

Authored by atul on Jun 6 2023, 11:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 25, 6:33 AM
Unknown Object (File)
Tue, Feb 25, 4:57 AM
Unknown Object (File)
Sat, Feb 22, 5:23 PM
Unknown Object (File)
Feb 18 2025, 12:16 PM
Unknown Object (File)
Jan 12 2025, 4:09 PM
Unknown Object (File)
Dec 28 2024, 9:56 PM
Unknown Object (File)
Dec 28 2024, 9:56 PM
Unknown Object (File)
Dec 28 2024, 9:56 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMM8e53b360b3d7: [native] Navigate to newly created community after successful creation
Summary

Navigate to the newly created community after succesful community creation.

Depends on D8129

Test Plan
  1. Create new community
  2. Observe that we are navigated to newly created community thread

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8130 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
native/
community-creation/
16 lines

Diff 27565

View Options

native/community-creation/community-creation-members.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { FlatList, Platform } from 'react-native'; import { FlatList, Platform } from 'react-native';
import { SafeAreaView } from 'react-native-safe-area-context'; import { SafeAreaView } from 'react-native-safe-area-context';
import { useSelector } from 'react-redux'; import { useSelector } from 'react-redux';
import { import {
childThreadInfos, childThreadInfos,
communityThreadSelector, communityThreadSelector,
} from 'lib/selectors/thread-selectors'; } from 'lib/selectors/thread-selectors';
import { threadIsChannel } from 'lib/shared/thread-utils'; import {
import { type ThreadInfo, communitySubthreads } from 'lib/types/thread-types'; createRecursiveDrawerItemsData,
appendSuffix,
} from 'lib/utils/drawer-utils.react';
import { useNavigateToThread } from '../chat/message-list-types'; import { useNavigateToThread } from '../chat/message-list-types';
import { useStyles } from '../themes/colors'; import { useStyles } from '../themes/colors';
import type { TextStyle } from '../types/styles';
import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react'; import CommunityDrawerItemCommunity from './community-drawer-item-cummunity.react';
const maxDepth = 2; const maxDepth = 2;
const safeAreaEdges = Platform.select({ const safeAreaEdges = Platform.select({
ios: ['top'], ios: ['top'],
default: ['top', 'bottom'], default: ['top', 'bottom'],
}); });
Show All 10 Linesfunction CommunityDrawerContent(): React.Node {
const navigateToThread = useNavigateToThread(); const navigateToThread = useNavigateToThread();
const childThreadInfosMap = useSelector(childThreadInfos); const childThreadInfosMap = useSelector(childThreadInfos);
const setOpenCommunnityOrClose = React.useCallback((index: string) => { const setOpenCommunnityOrClose = React.useCallback((index: string) => {
setOpenCommunity(open => (open === index ? null : index)); setOpenCommunity(open => (open === index ? null : index));
}, []); }, []);
const renderItem = React.useCallback( const renderItem = React.useCallback(
({ item }) => { ({ item }) => {
const itemData = {
threadInfo: item.threadInfo,
itemChildren: item.itemChildren,
labelStyle: item.labelStyle,
hasSubchannelsButton: item.subchannelsButton,
};
return ( return (
<CommunityDrawerItemCommunity <CommunityDrawerItemCommunity
key={item.key} key={item.threadInfo.id}
itemData={itemData} itemData={item}
toggleExpanded={setOpenCommunnityOrClose} toggleExpanded={setOpenCommunnityOrClose}
expanded={itemData.threadInfo.id === openCommunity} expanded={item.threadInfo.id === openCommunity}
navigateToThread={navigateToThread} navigateToThread={navigateToThread}
/> />
); );
}, },
michalUnsubmitted
Not Done
Inline Actions
}, []);
const renderItem = React.useCallback(
- ({ item }) => {
- return (
+ ({ item }) => (
<CommunityDrawerItemCommunity
key={item.threadInfo.id}
itemData={item}
toggleExpanded={setOpenCommunnityOrClose}
expanded={item.threadInfo.id === openCommunity}
navigateToThread={navigateToThread}
/>
- );
- },
+ ),
[navigateToThread, openCommunity, setOpenCommunnityOrClose],

This now can be simplified.

michal: This now can be simplified.
[navigateToThread, openCommunity, setOpenCommunnityOrClose], [navigateToThread, openCommunity, setOpenCommunnityOrClose],
); );
const labelStylesObj = useStyles(labelUnboundStyles); const labelStylesObj = useStyles(labelUnboundStyles);
const labelStyles = React.useMemo( const labelStyles = React.useMemo(
() => [ () => [
labelStylesObj.level0Label, labelStylesObj.level0Label,
labelStylesObj.level1Label, labelStylesObj.level1Label,
labelStylesObj.level2Label, labelStylesObj.level2Label,
], ],
[labelStylesObj], [labelStylesObj],
); );
const drawerItemsData = React.useMemo( const drawerItemsData = React.useMemo(
() => () =>
createRecursiveDrawerItemsData( createRecursiveDrawerItemsData(
childThreadInfosMap, childThreadInfosMap,
communitiesSuffixed, communitiesSuffixed,
labelStyles, labelStyles,
maxDepth,
), ),
[childThreadInfosMap, communitiesSuffixed, labelStyles], [childThreadInfosMap, communitiesSuffixed, labelStyles],
); );
return ( return (
<SafeAreaView style={styles.drawerContent} edges={safeAreaEdges}> <SafeAreaView style={styles.drawerContent} edges={safeAreaEdges}>
<FlatList data={drawerItemsData} renderItem={renderItem} /> <FlatList data={drawerItemsData} renderItem={renderItem} />
</SafeAreaView> </SafeAreaView>
); );
} }
function createRecursiveDrawerItemsData(
childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
communities: $ReadOnlyArray<ThreadInfo>,
labelStyles: $ReadOnlyArray<TextStyle>,
) {
const result = communities.map(community => ({
key: community.id,
threadInfo: community,
itemChildren: [],
labelStyle: labelStyles[0],
subchannelsButton: false,
}));
let queue = result.map(item => [item, 0]);
for (let i = 0; i < queue.length; i++) {
const [item, lvl] = queue[i];
const itemChildThreadInfos = childThreadInfosMap[item.threadInfo.id] ?? [];
if (lvl < maxDepth) {
item.itemChildren = itemChildThreadInfos
.filter(childItem => communitySubthreads.includes(childItem.type))
.map(childItem => ({
threadInfo: childItem,
itemChildren: [],
labelStyle: labelStyles[Math.min(lvl + 1, labelStyles.length - 1)],
hasSubchannelsButton:
lvl + 1 === maxDepth &&
threadHasSubchannels(childItem, childThreadInfosMap),
}));
queue = queue.concat(
item.itemChildren.map(childItem => [childItem, lvl + 1]),
);
}
}
return result;
}
function threadHasSubchannels(
threadInfo: ThreadInfo,
childThreadInfosMap: { +[id: string]: $ReadOnlyArray<ThreadInfo> },
) {
if (!childThreadInfosMap[threadInfo.id]?.length) {
return false;
}
return childThreadInfosMap[threadInfo.id].some(thread =>
threadIsChannel(thread),
);
}
function appendSuffix(chats: $ReadOnlyArray<ThreadInfo>): ThreadInfo[] {
const result = [];
const names = new Map<string, number>();
for (const chat of chats) {
let name = chat.uiName;
const numberOfOccurrences = names.get(name);
names.set(name, (numberOfOccurrences ?? 0) + 1);
if (numberOfOccurrences) {
name = `${name} (${numberOfOccurrences.toString()})`;
}
result.push({ ...chat, uiName: name });
}
return result;
}
const unboundStyles = { const unboundStyles = {
drawerContent: { drawerContent: {
flex: 1, flex: 1,
paddingRight: 8, paddingRight: 8,
paddingTop: 8, paddingTop: 8,
backgroundColor: 'drawerBackgroud', backgroundColor: 'drawerBackgroud',
}, },
}; };
Show All 26 Lines