[lib] Unify duplicated avatar tcomb validators
ClosedPublic
Actions

Authored by ashoat on Jun 7 2023, 12:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 10, 1:59 PM

	Unknown Object (File)
	Tue, Nov 5, 9:14 AM

	Unknown Object (File)
	Thu, Oct 31, 7:42 AM

	Unknown Object (File)
	Sun, Oct 27, 8:19 AM

	Unknown Object (File)
	Tue, Oct 22, 2:57 PM

	Unknown Object (File)
	Fri, Oct 18, 9:43 PM

	Unknown Object (File)
	Fri, Oct 18, 9:43 PM

	Unknown Object (File)
	Sep 28 2024, 9:53 PM

View All 59 Files

Subscribers

tomek

Details

Reviewers

ginsu
atul

Commits

rCOMM375f45edc017: [lib] Unify duplicated avatar tcomb validators

Summary

Noticed that we had two duplicated validators for avatar types. This diff unifies them, and opts for the more specific validator where there were differences (in just one case).

Depends on D8146

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jun 7 2023, 12:32 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 7 2023, 12:32 PM

Harbormaster completed remote builds in B20095: Diff 27535.Jun 7 2023, 12:51 PM

ashoat requested review of this revision.Jun 7 2023, 12:51 PM

atul accepted this revision.Jun 7 2023, 1:14 PM

This revision is now accepted and ready to land.Jun 7 2023, 1:14 PM

Closed by commit rCOMM375f45edc017: [lib] Unify duplicated avatar tcomb validators (authored by ashoat). · Explain WhyJun 7 2023, 2:05 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM375f45edc017: [lib] Unify duplicated avatar tcomb validators.

Revision Contents
Changeset List

Path

Size

lib/

types/

avatar-types.js

20 lines

utils/

avatar-utils.js

28 lines

Diff 27539

View Options

lib/types/avatar-types.js