Page MenuHomePhabricator
Differential D8204

[native] Fix invite link button positioning
ClosedPublic
Actions

Authored by tomek on Jun 14 2023, 3:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:42 PM
Unknown Object (File)
Sat, Mar 8, 12:39 PM
Unknown Object (File)
Feb 26 2025, 3:32 PM
Unknown Object (File)
Feb 26 2025, 12:24 PM
Unknown Object (File)
Feb 14 2025, 1:00 PM
View All Files
Subscribers
ashoat

Details

Reviewers
bartek
kamil
inka
• ted
Commits
rCOMM3dd3b9b9d78a: [native] Fix invite link button positioning
Summary

The button was positioned incorrectly and was overlapping with long community name. Also, community name could fill the whole available space.

button-next.png (2×1 px, 277 KB)

Test Plan

Check if the button is displayed correctly even when the name is long.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
invite-links/
20 lines
navigation/
4 lines

Diff 27924

View Options

native/invite-links/invite-links-button.react.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines
View Options

native/navigation/community-drawer-item.react.js

Show First 20 Lines • Show All 108 Lines • ▼ Show 20 Linesfunction getUploadURL(id: string, secret: string): string {
if (isDev) { if (isDev) {
const ipV4 = ip.v4.sync() || 'localhost'; const ipV4 = ip.v4.sync() || 'localhost';
const port = parseInt(process.env.PORT, 10) || 3000; const port = parseInt(process.env.PORT, 10) || 3000;
return `http://${ipV4}:${port}${uploadPath}`; return `http://${ipV4}:${port}${uploadPath}`;
} }
return `${baseDomain}${uploadPath}`; return `${baseDomain}${uploadPath}`;
} }
function makeUploadURI(holder: ?string, id: string, secret: string): string { function makeUploadURI(blobHash: ?string, id: string, secret: string): string {
if (holder) { if (blobHash) {
return makeBlobServiceURI(holder); return makeBlobServiceURI(blobHash);
} }
return getUploadURL(id, secret); return getUploadURL(id, secret);
} }
function imagesFromRow(row: Object): Image | EncryptedImage { function imagesFromRow(row: Object): Image | EncryptedImage {
const uploadExtra = JSON.parse(row.uploadExtra); const uploadExtra = JSON.parse(row.uploadExtra);
const { width, height, blobHash, thumbHash } = uploadExtra; const { width, height, blobHash, thumbHash } = uploadExtra;
▲ Show 20 Lines • Show All 280 Lines • Show Last 20 Lines