Page MenuHomePhabricator
Differential D8229

[landing] remove max from team page
ClosedPublic
Actions

Authored by ginsu on Jun 15 2023, 12:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 31 2024, 5:58 PM
Unknown Object (File)
Mar 31 2024, 5:58 PM
Unknown Object (File)
Mar 31 2024, 5:56 PM
Unknown Object (File)
Mar 31 2024, 5:41 PM
Unknown Object (File)
Feb 27 2024, 1:58 AM
Unknown Object (File)
Feb 27 2024, 1:58 AM
Unknown Object (File)
Feb 27 2024, 1:58 AM
Unknown Object (File)
Feb 27 2024, 1:55 AM
View All 24 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
ashoat
Commits
rCOMMd1c23970e365: [landing] remove max from team page
Summary

remove max from the team page

Test Plan

Please see screenshot below

Screenshot 2023-06-15 at 3.40.28 PM.png (1×3 px, 2 MB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 15 2023, 12:41 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 15 2023, 12:41 PM
ginsu published this revision for review.Jun 15 2023, 12:43 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, kamil, ashoat.
ginsu attached a referenced file: F589939: Screenshot 2023-06-15 at 3.40.28 PM.png. (Show Details)
ashoat accepted this revision.Jun 15 2023, 12:52 PM
ashoat added inline comments.
landing/team.react.js
57 ↗(On Diff #27811)

Is there an image that needs to be removed too?

This revision is now accepted and ready to land.Jun 15 2023, 12:52 PM
ginsu added inline comments.Jun 15 2023, 12:55 PM
landing/team.react.js
57 ↗(On Diff #27811)

yup deleted the image from s3

Screenshot 2023-06-15 at 3.55.15 PM.png (1×3 px, 681 KB)

ginsu attached a referenced file: F589943: Screenshot 2023-06-15 at 3.55.15 PM.png. (Show Details)Jun 15 2023, 12:56 PM
ashoat added inline comments.Jun 15 2023, 12:59 PM
landing/team.react.js
57 ↗(On Diff #27811)

Hold on, shouldn't we wait until the new landing page in live on prod to delete the image from S3? It still appears to be loading but I'm not sure how long that will last...

ginsu added inline comments.Jun 15 2023, 1:01 PM
landing/team.react.js
57 ↗(On Diff #27811)

No shit you are right, let me reupload the image

Harbormaster completed remote builds in B20289: Diff 27811.Jun 15 2023, 1:01 PM
ginsu added inline comments.Jun 15 2023, 1:07 PM
landing/team.react.js
57 ↗(On Diff #27811)

Okay image is reuploaded, sorry about that brain fart

Closed by commit rCOMMd1c23970e365: [landing] remove max from team page (authored by ginsu). · Explain WhyJun 15 2023, 1:08 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMd1c23970e365: [landing] remove max from team page.

Revision Contents
Changeset List

PathSize
landing/
7 lines

Diff 27812

View Options

landing/team.react.js

Loading...