Details
- Reviewers
ashoat ginsu - Commits
- rCOMM5586b22448b8: [web] Introduce `EditUserAvatarMenu`
Looks as expected:
(Used icons + copy from native, the Figma designs are pretty old)
(Right now the menu items appear to the left of the button, will need to modify Menu to be able to display items to the right of the button... will defer this)
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| web/avatars/edit-user-avatar-menu.react.js | ||
|---|---|---|
| 20 ↗ | (On Diff #27853) | Right now MenuItem takes an icon: string prop which is restricted to SWMansion icons. However, we'll need to modify MenuItem to take React.Node so we can pass in CommIcon for the ENS option. Deferring that for later. |
| web/avatars/edit-user-avatar-menu.react.js | ||
|---|---|---|
| 11–32 ↗ | (On Diff #27853) | Any time you're using React.useMemo with an empty dep list, that's usually a sign you can factor that to the top-level scope. I'm guessing the MenuItems will have to be defined in the component once you add handlers, but editIcon at least seems like it can be defined at the top-level scope |
| web/avatars/edit-user-avatar-menu.react.js | ||
|---|---|---|
| 11–32 ↗ | (On Diff #27853) | Ah yeah, the MenuItems will have handlers, but editIcon could totally be defined outside. Will update this diff. |