Page MenuHomePhabricator
Differential D8276

Introduce NEW_CODE_VERSION constant
ClosedPublic
Actions

Authored by marcin on Jun 21 2023, 8:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 2:09 PM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Mon, Nov 11, 12:47 AM
Unknown Object (File)
Tue, Nov 5, 2:11 AM
Unknown Object (File)
Sep 29 2024, 6:13 AM
View All 90 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
Commits
rCOMMab924f2faa25: Introduce NEW_CODE_VERSION constant
Summary

This differential introduces NEW_CODE_VERSION constant that will be replaced with the latest code version upon every release

Test Plan

CI passing.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Jun 21 2023, 8:08 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2023, 8:08 AM
marcin updated this revision to Diff 27953.Jun 21 2023, 8:12 AM

Rebase to update commit message

marcin added 1 blocking reviewer(s): atul.Jun 21 2023, 8:12 AM
Harbormaster completed remote builds in B20398: Diff 27952.Jun 21 2023, 9:48 AM
Harbormaster completed remote builds in B20399: Diff 27953.Jun 21 2023, 9:55 AM
marcin requested review of this revision.Jun 21 2023, 9:55 AM
marcin added a child revision: D8245: Manually serialize notification data to avoid passing encrypted notification to JavaScript.Jun 22 2023, 8:30 AM
atul accepted this revision.Jun 22 2023, 11:13 AM
This revision is now accepted and ready to land.Jun 22 2023, 11:13 AM
atul added a comment.Jun 22 2023, 11:13 AM

Maybe next code version?

marcin updated this revision to Diff 28139.Jun 27 2023, 1:27 AM

REbase before landing

Harbormaster completed remote builds in B20525: Diff 28139.Jun 27 2023, 1:43 AM
Closed by commit rCOMMab924f2faa25: Introduce NEW_CODE_VERSION constant (authored by marcin). · Explain WhyJun 27 2023, 1:56 AM
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMMab924f2faa25: Introduce NEW_CODE_VERSION constant.
ashoat added a comment.Jun 27 2023, 5:49 AM

Maybe next code version?

Yeah I think that would be better

marcin added a comment.Jun 27 2023, 6:00 AM
In D8276#245705, @ashoat wrote:

Maybe next code version?

Yeah I think that would be better

Please accept my apologies for not including this change. It was unintentional of to skip this comment. I will change it before EOD today.

atul added a comment.Jun 27 2023, 7:29 AM

I will change it before EOD today.

Instead of a new diff, you could probably revert, re-open, change NEW_CODE_VERSION to NEXT_CODE_VERSION and land without another review

Revision Contents
Changeset List

PathSize
lib/
shared/
8 lines

Diff 28139

View Options

lib/shared/version-utils.js

Loading...