Paths

Table of Contentst

[native] Quick fix for EnumSettingsOption
ClosedPublic
Actions

Authored by rohan on Jun 26 2023, 10:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 30, 9:38 AM

	Unknown Object (File)
	Mon, Dec 30, 9:38 AM

	Unknown Object (File)
	Mon, Dec 30, 9:38 AM

	Unknown Object (File)
	Mon, Dec 30, 9:37 AM

	Unknown Object (File)
	Nov 23 2024, 2:08 PM

	Unknown Object (File)
	Nov 23 2024, 2:07 PM

	Unknown Object (File)
	Nov 23 2024, 2:07 PM

	Unknown Object (File)
	Nov 23 2024, 2:07 PM

View All Files

Subscribers

ashoat

tomek

Details

Reviewers

atul

Commits

rCOMM3e9441b981dc: [native] Quick fix for EnumSettingsOption

Summary

Sorry, forgot to (1) address the description length feedback and
(2) missed the ! operator for checking for an icon prop.

Test Plan

Confirmed that the EnumSettingsOption works correctly with
the new description variable and with an icon

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Jun 26 2023, 10:39 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 26 2023, 10:39 AM

Harbormaster completed remote builds in B20509: Diff 28120.Jun 26 2023, 10:56 AM

rohan requested review of this revision.Jun 26 2023, 10:57 AM

Thanks for making this followup diff

This revision is now accepted and ready to land.Jun 26 2023, 1:05 PM

Closed by commit rCOMM3e9441b981dc: [native] Quick fix for EnumSettingsOption (authored by rohan). · Explain WhyJun 26 2023, 1:11 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM3e9441b981dc: [native] Quick fix for EnumSettingsOption.

Revision Contents
Changeset List

Path

Size

native/

community-creation/

community-configuration.react.js

6 lines

components/

enum-settings-option.react.js

2 lines

Diff 28122

View Options

native/community-creation/community-configuration.react.js