[keyserver] Fetch primary links only when a user is logged in
ClosedPublic
Actions

Authored by tomek on Jun 27 2023, 7:09 AM.

Details

Reviewers

kamil
inka
michal
ashoat

Commits

rCOMMc9e4b84ef13c: [keyserver] Fetch primary links only when a user is logged in

Summary

Calling userID getter on Viewer results in an exception when a user isn't logged in. A logged out user shouldn't have access to invite links, so we can return an empty array for them.

https://linear.app/comm/issue/ENG-4185/cant-open-web-app-if-not-already-logged-in-dev#comment-6dba4247

Test Plan

Open web app as a logged out user and check if it loads correctly. Log in and check if the links are fetched.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jun 27 2023, 7:09 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJun 27 2023, 7:09 AM

Harbormaster completed remote builds in B20540: Diff 28167.Jun 27 2023, 7:26 AM

tomek requested review of this revision.Jun 27 2023, 7:26 AM

ashoat accepted this revision.Jun 27 2023, 7:26 AM

This revision is now accepted and ready to land.Jun 27 2023, 7:26 AM

Closed by commit rCOMMc9e4b84ef13c: [keyserver] Fetch primary links only when a user is logged in (authored by tomek). · Explain WhyJun 27 2023, 7:27 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMc9e4b84ef13c: [keyserver] Fetch primary links only when a user is logged in.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

fetchers/

link-fetchers.js

4 lines

Diff 28168

View Options

keyserver/src/fetchers/link-fetchers.js

[keyserver] Fetch primary links only when a user is logged inClosedPublicActions