[keyserver] cron job to sync reserved usernames
ClosedPublic
Actions

Authored by varun on Jun 27 2023, 7:45 AM.

Details

Reviewers

Commits

rCOMM1dc6de0da76b: [keyserver] cron job to sync reserved usernames
rCOMM9a75d885847d: [keyserver] cron job to sync reserved usernames

Summary

daily cron job to send all the usernames from ashoat's keyserver to the identity service.

the logic here is very similar to the logic added to the account-creator.js

Depends on D8330

Test Plan

Modified cron job schedule to force a run and observed that usernames were added to the identity service's reserved usernames table locally

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Jun 27 2023, 7:45 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 7:45 AM

Harbormaster completed remote builds in B20544: Diff 28174.Jun 27 2023, 8:03 AM

varun requested review of this revision.Jun 27 2023, 8:03 AM

Instead of syncing it using chron, can't we call the API as a part of user registration / account deletion?

In D8331#245829, @tomek wrote:

Instead of syncing it using chron, can't we call the API as a part of user registration / account deletion?

We do that as well in D8300. This change is just for initial syncing and then in case of a network failure or identity service issue

ashoat accepted this revision.Jun 28 2023, 5:42 PM

ashoat added inline comments.

keyserver/src/cron/add-reserved-usernames.js
11 ↗	(On Diff #28174)	Let's name it more precisely
keyserver/src/cron/cron.js
96 ↗	(On Diff #28174)	It seems like we'll need to make sure this only runs on my keyserver. Can you create a follow-up Linear task before landing for this? If you don't already have a parent task for follow-ups, you can create one and add the new task as a child
103 ↗	(On Diff #28174)

This revision is now accepted and ready to land.Jun 28 2023, 5:42 PM

varun added inline comments.Jun 30 2023, 9:58 PM

keyserver/src/cron/cron.js
96 ↗	(On Diff #28174)	https://linear.app/comm/issue/ENG-4298/make-sure-updateidentityreservedusernames-cron-job-only-runs-on

Closed by commit rCOMM9a75d885847d: [keyserver] cron job to sync reserved usernames (authored by varun). · Explain WhyJul 3 2023, 9:10 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM9a75d885847d: [keyserver] cron job to sync reserved usernames.

varun added a reverting change: rCOMM897c86fd3481: Revert "[keyserver] cron job to sync reserved usernames".Jul 3 2023, 9:36 PM

varun reopened this revision.Jul 3 2023, 9:42 PM

This revision is now accepted and ready to land.Jul 3 2023, 9:42 PM

Closed by commit rCOMM1dc6de0da76b: [keyserver] cron job to sync reserved usernames (authored by varun). · Explain WhyJul 3 2023, 9:44 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM1dc6de0da76b: [keyserver] cron job to sync reserved usernames.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

cron/

cron.js

16 lines

update-identity-reserved-usernames.js

28 lines

Diff 28373

View Options

keyserver/src/cron/cron.js

	#include "CommCoreModule.h"			#include "CommCoreModule.h"
	#include "../CryptoTools/DeviceID.h"			#include "../CryptoTools/DeviceID.h"
	#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"			#include "../Notifications/BackgroundDataStorage/NotificationsCryptoModule.h"
	#include "BaseDataStore.h"			#include "BaseDataStore.h"
	#include "DatabaseManager.h"			#include "DatabaseManager.h"
	#include "InternalModules/GlobalDBSingleton.h"			#include "InternalModules/GlobalDBSingleton.h"
	#include "InternalModules/RustPromiseManager.h"
	#include "NativeModuleUtils.h"			#include "NativeModuleUtils.h"
	#include "TerminateApp.h"			#include "TerminateApp.h"
	#include "lib.rs.h"

	#include <ReactCommon/TurboModuleUtils.h>			#include <ReactCommon/TurboModuleUtils.h>
	#include <folly/dynamic.h>			#include <folly/dynamic.h>
	#include <folly/json.h>			#include <folly/json.h>
	#include <future>			#include <future>

	namespace comm {			namespace comm {

	▲ Show 20 Lines • Show All 782 Lines • ▼ Show 20 Lines
	bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {			bool CommCoreModule::checkIfDatabaseNeedsDeletion(jsi::Runtime &rt) {
	return DatabaseManager::checkIfDatabaseNeedsDeletion();			return DatabaseManager::checkIfDatabaseNeedsDeletion();
	}			}

	void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {			void CommCoreModule::reportDBOperationsFailure(jsi::Runtime &rt) {
	DatabaseManager::reportDBOperationsFailure();			DatabaseManager::reportDBOperationsFailure();
	}			}

	jsi::Value CommCoreModule::generateNonce(jsi::Runtime &rt) {
	return createPromiseAsJSIValue(
	rt, [this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityGenerateNonce(currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::registerUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityRegisterUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginPasswordUser(
	jsi::Runtime &rt,
	jsi::String username,
	jsi::String password,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&username,
	&password,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys](
	jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginPasswordUser(
	jsiStringToRustString(username, innerRt),
	jsiStringToRustString(password, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	jsi::Value CommCoreModule::loginWalletUser(
	jsi::Runtime &rt,
	jsi::String siweMessage,
	jsi::String siweSignature,
	jsi::String keyPayload,
	jsi::String keyPayloadSignature,
	jsi::String contentPrekey,
	jsi::String contentPrekeySignature,
	jsi::String notifPrekey,
	jsi::String notifPrekeySignature,
	jsi::Array contentOneTimeKeys,
	jsi::Array notifOneTimeKeys,
	jsi::String socialProof) {
	return createPromiseAsJSIValue(
	rt,
	[this,
	&siweMessage,
	&siweSignature,
	&keyPayload,
	&keyPayloadSignature,
	&contentPrekey,
	&contentPrekeySignature,
	&notifPrekey,
	&notifPrekeySignature,
	&contentOneTimeKeys,
	&notifOneTimeKeys,
	&socialProof](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
	std::string error;
	try {
	auto currentID = RustPromiseManager::instance.addPromise(
	promise, this->jsInvoker_, innerRt);
	identityLoginWalletUser(
	jsiStringToRustString(siweMessage, innerRt),
	jsiStringToRustString(siweSignature, innerRt),
	jsiStringToRustString(keyPayload, innerRt),
	jsiStringToRustString(keyPayloadSignature, innerRt),
	jsiStringToRustString(contentPrekey, innerRt),
	jsiStringToRustString(contentPrekeySignature, innerRt),
	jsiStringToRustString(notifPrekey, innerRt),
	jsiStringToRustString(notifPrekeySignature, innerRt),
	jsiStringArrayToRustVec(contentOneTimeKeys, innerRt),
	jsiStringArrayToRustVec(notifOneTimeKeys, innerRt),
	jsiStringToRustString(socialProof, innerRt),
	currentID);
	} catch (const std::exception &e) {
	error = e.what();
	};
	});
	}

	} // namespace comm			} // namespace comm