Differential D8337

[web] Handle unsaved changes if the modal close button is clicked
ClosedPublic
Actions

Authored by rohan on Jun 27 2023, 11:16 AM.

Tags

None

Referenced Files

	F3374067: D8337.diff
	Tue, Nov 26, 1:37 PM

	F3367437: D8337.id28216.diff
	Mon, Nov 25, 2:50 PM

	F3367434: D8337.id28186.diff
	Mon, Nov 25, 2:50 PM

	Unknown Object (File)
	Sat, Nov 23, 2:24 PM

	Unknown Object (File)
	Sat, Nov 23, 2:23 PM

	Unknown Object (File)
	Sun, Nov 17, 11:02 PM

	Unknown Object (File)
	Sat, Nov 9, 2:01 PM

	Unknown Object (File)
	Sat, Nov 9, 10:03 AM

Subscribers

Details

Reviewers

atul
ashoat

Commits

rCOMMfb164b4859b0: [web] Handle unsaved changes if the modal close button is clicked

Summary

Some feedback from @ashoat in D8139 made me realize that even though clicking 'Back' will prompt an unsaved changes modal if necessary, clicking the default close icon on the modal doesn't. This diff is a really simple change to mirror behavior across both close methods.

Test Plan

Verified that now both methods of exiting the modal will prompt unsaved changes if there are any.

Diff Detail

Repository

Branch

change_roles-quickfix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Jun 27 2023, 11:16 AM

Herald added a subscriber: tomek. · View Herald TranscriptJun 27 2023, 11:16 AM

rohan edited the summary of this revision. (Show Details)Jun 27 2023, 11:17 AM

rohan edited the test plan for this revision. (Show Details)

rohan attached a referenced file: F609655: Screen Recording 2023-06-27 at 2.16.15 PM.mov. (Show Details)

rohan added a child revision: D8338: [web] Use colors from themes.css in dropdown.Jun 27 2023, 11:26 AM

Harbormaster completed remote builds in B20552: Diff 28186.Jun 27 2023, 11:33 AM

rohan requested review of this revision.Jun 27 2023, 11:33 AM

Looks reasonable, thanks for including the video

This revision is now accepted and ready to land.Jun 28 2023, 10:29 AM

Closed by commit rCOMMfb164b4859b0: [web] Handle unsaved changes if the modal close button is clicked (authored by rohan). · Explain WhyJun 28 2023, 10:38 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMfb164b4859b0: [web] Handle unsaved changes if the modal close button is clicked.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

change-member-role-modal.react.js

6 lines

Diff 28186

web/modals/threads/members/change-member-role-modal.react.js

Loading...