Page MenuHomePhabricator
Differential D8338

[web] Use colors from themes.css in dropdown
ClosedPublic
Actions

Authored by rohan on Jun 27 2023, 11:26 AM.
Tags
None
Referenced Files
F3200851: D8338.id28187.diff
Sat, Nov 9, 2:45 PM
F3200548: D8338.id28215.diff
Sat, Nov 9, 2:01 PM
Unknown Object (File)
Sat, Nov 9, 12:16 PM
Unknown Object (File)
Sat, Nov 9, 8:38 AM
Unknown Object (File)
Thu, Nov 7, 7:32 PM
Unknown Object (File)
Sep 28 2024, 6:59 PM
Unknown Object (File)
Sep 28 2024, 6:59 PM
Unknown Object (File)
Sep 28 2024, 6:59 PM
View All 76 Files
Subscribers
• ted
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM2bb6d801c1fd: [web] Use colors from themes.css in dropdown
Summary

Some feedback in D8136 was to use colors from themes.css instead of inlining them in SWMansionIcon.

Depends on D8337

Test Plan

Confirmed that both enabled and disabled dropdowns still look the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Jun 27 2023, 11:26 AM
Herald added subscribers: • ted, tomek. · View Herald TranscriptJun 27 2023, 11:26 AM
Harbormaster completed remote builds in B20553: Diff 28187.Jun 27 2023, 11:44 AM
rohan requested review of this revision.Jun 27 2023, 11:44 AM
rohan mentioned this in D8136: [web] Implement a custom dropdown menu component.Jun 27 2023, 12:12 PM
atul accepted this revision.Jun 28 2023, 10:26 AM

Let's make sure to fix typo before landing

web/components/dropdown.react.js
39 ↗(On Diff #28187)

Do we need !!disabled, or can we just do disabled?

web/theme.css
235 ↗(On Diff #28187)

Minor typo, should be dropdown instead of dropddown

This revision is now accepted and ready to land.Jun 28 2023, 10:26 AM
atul added inline comments.Jun 28 2023, 10:28 AM
web/components/dropdown.react.js
39 ↗(On Diff #28187)

I guess we do !!disabled above in the other calls to classNames, so it's probably best to maintain consistency.

rohan added inline comments.Jun 28 2023, 10:34 AM
web/theme.css
235 ↗(On Diff #28187)

Oh yeah thanks for catching that

rohan updated this revision to Diff 28215.Jun 28 2023, 10:35 AM

Typo

This revision was landed with ongoing or failed builds.Jun 28 2023, 10:38 AM
Closed by commit rCOMM2bb6d801c1fd: [web] Use colors from themes.css in dropdown (authored by rohan). · Explain Why
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM2bb6d801c1fd: [web] Use colors from themes.css in dropdown.
Harbormaster completed remote builds in B20580: Diff 28215.Jun 28 2023, 10:52 AM

Revision Contents
Changeset List

PathSize
web/
components/
1 line
8 lines
1 line

Diff 28217

View Options

web/components/dropdown.css

Loading...
View Options

web/components/dropdown.react.js

Loading...
View Options

web/theme.css

Loading...