Page MenuHomePhabricator
Differential D8362

[web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`
ClosedPublic
Actions

Authored by atul on Jun 28 2023, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 2:25 PM
Unknown Object (File)
Sat, Nov 23, 1:20 PM
Unknown Object (File)
Sat, Nov 23, 1:20 PM
Unknown Object (File)
Sat, Nov 23, 9:49 AM
Unknown Object (File)
Sat, Nov 23, 7:08 AM
Unknown Object (File)
Sat, Nov 23, 7:08 AM
Unknown Object (File)
Mon, Nov 11, 1:42 PM
Unknown Object (File)
Fri, Nov 1, 6:36 PM
View All Files
Subscribers
tomek

Details

Reviewers
ashoat
ginsu
Commits
rCOMMeb4630c6ba30: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`
Summary

Current emoji Picker for reactions changes theme based on OS mode.

Instead we set to always be dark to match rest of web.

We also set autoFocus to true so user can begin typing as soon as the emoji picker is opened

Test Plan

Looks as expected

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D8362 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Jun 28 2023, 1:25 PM
Herald added a subscriber: tomek. · View Herald TranscriptJun 28 2023, 1:25 PM
atul published this revision for review.Jun 28 2023, 1:25 PM
ashoat accepted this revision.Jun 28 2023, 1:26 PM
This revision is now accepted and ready to land.Jun 28 2023, 1:26 PM
ginsu accepted this revision.Jun 28 2023, 1:26 PM

thanks for addressing this!

atul updated this revision to Diff 28231.Jun 28 2023, 1:28 PM

include autofocus change

atul retitled this revision from [web] Set emoji `Picker` to always be "dark" mode to [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`.Jun 28 2023, 1:29 PM
atul edited the summary of this revision. (Show Details)
atul updated this revision to Diff 28232.Jun 28 2023, 1:34 PM

cherrypick and land

This revision was landed with ongoing or failed builds.Jun 28 2023, 1:38 PM
Closed by commit rCOMMeb4630c6ba30: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMeb4630c6ba30: [web] Set emoji `Picker` to "dark" mode and set search box to `autoFocus`.
Harbormaster completed remote builds in B20593: Diff 28230.Jun 28 2023, 2:13 PM
Harbormaster completed remote builds in B20594: Diff 28231.Jun 28 2023, 2:22 PM
Harbormaster completed remote builds in B20595: Diff 28232.Jun 28 2023, 2:26 PM

Revision Contents
Changeset List

PathSize
web/
chat/
7 lines

Diff 28232

View Options

web/chat/message-tooltip.react.js

Loading...